prestashopcorp / bluesnap Goto Github PK

I have just made a new test with BlueSnap and I'm glad to see an order is not created anymore before the payment process.

But I'm still facing other issues:

• When the payment is completed, there is no way to go back to the shop (and validate the order)
• I cant pay an other amount than the price fixed in the BlueSnap interface with a contract number.

I have tested the module in the branch 16 and I find his content really more interesting on PrestaShop 1.6. Thanks.

But I saw that it is also only compliant with this PrestaShop version and I guess you want to make the module working on 1.5.X (Maybe 1.4.X too).
To do so, I let you merge the two branches and write the .tpl files which could best fit to each version.

With the branch 16, I'm unable to see what is stored on the configuration page.

I checked in the database and I found my configuration, but I also found that the names of my configuration data is always in lower case for bluesnap:

For information I tried to convert them in uppercase, but nothing changed. :(

On the following link, you will find a report in which we wrote many comments about the module. We got a fatal error when we tried to checkout, so we couldn't test everything. Please have a look on the document and let me know here if you need more information.

-> Report

In this file, I found that you create many rows which are hidden if a condition is not respected.
It seems that nothing make these rows appear after the page has loaded. Maybe we could remove the display="display:none;" and move the tests outside the <tr> </tr> tags.

If we do this, the following code

{if $total_shipping_tax_exc <= 0 && !isset($virtualCart)}
    <tr class="cart_total_delivery" style="{if !isset($carrier->id) || is_null($carrier->id)}display:none;{/if}">
        <td colspan="5">{l s='Shipping' mod='bluesnap'}</td>
        <td colspan="2" class="price" id="total_shipping">{l s='Free Shipping!' mod='bluesnap'}</td>
    </tr>
{else}

would become

{if $total_shipping_tax_exc <= 0 && !isset($virtualCart)}
    {if !isset($carrier->id) || is_null($carrier->id)}
        <tr class="cart_total_delivery">
            <td colspan="5">{l s='Shipping' mod='bluesnap'}</td>
            <td colspan="2" class="price" id="total_shipping">{l s='Free Shipping!' mod='bluesnap'}</td>
        </tr>
    {/if}
{else}

The answer you sent by mail has been forwarded to me.

When the user click on the button “Continue to secure order form”, an order is created with the payment status “Awaiting BlueSnap payment”. The process is wrong because if an error is thrown during the payment process on the BlueSnap interface and the customer wants to go back, he will find his cart empty.
In consequence, he won’t be able to try a new payment and the order will have to be deleted by the merchant.

You should create the order only in the callback.

We need to cypher id_order to pass the data on payment method so place order is necessary before the payment is made.

You could use the cart_id instead to find your information.

I insist on this issue, because you have to create the order only AFTER the payment on the BlueSnap interface, not just before. Don't hesitate to ask us if you need some help, but we can not validate the module if you keep this process.

classes/BluesnapApi.php

• l.124: You could return directly implode(...) instead of storing the value in a temporary variable
• l.207: You could return directly array(...) instead of storing the value in a temporary variable

classes/BluesnapIpn.php

• l.50 & 57: The variables $id_debug_mode and $id_log_name already exist in the parent class. You don't need to define them again in the class BluesnapIpn.