prestashopcorp / brinkscheckout Goto Github PK

When I reach the module settings page, I see that the subscription part take a lot of space.

The merchant has two options to subscribe:

• Click on the "Start selling now" button at the top of the page
• Fill the integrated form
• Click on the "Sign up" button

I wonder if the form is really useful if the merchant can also fill it on your website. We currently need to scroll a lot to reach the setup form

When a customer complete an order, it would be good to show a few information on the order confirmation page.

In example, the order reference and the price.

XSS (low severity)

views/templates/hook/1.6/payment_return.tpl:32 $reference
views/templates/hook/1.5/payment_return.tpl:32 $reference

views/templates/hook/1.6/payment_execution.tpl:44;45 $twocheckout_sid $twocheckout_public_key
views/templates/hook/1.5/payment_execution.tpl:44;45 $twocheckout_sid $twocheckout_public_key

lib/Twocheckout/TwocheckoutCharge.php
:18 $type
:29 $key $value
:42 $type

• The variable $$post_errors seems to be unused
• A bug has been discovered on different version of PS 1.5 with the ps_version_compliancy. Please comment it.
• function initConfigVars():
  • $this->public, $this->private, $this->sandbox seem to be not used in the whole file.
  • $this->sandbox can be overwritten twice with unrelated data
• function install():
  • The value returned from parent::install() should be checked before proceeding to the hooks registration.
• function installDb():
  • You can directly return Db::getInstance()->Execute(...)
• function processPayment():
  • You should check with Validate::isLoadedObject() if addresses, customer and order are properly instanciated
• l.488: You can check directly if (!empty($twocheckout_info[...])

During the tests, I did not have the Admin API Password. I am currently unable to complete the module setup.

But I tried anyway to create an order by paying with Brink's, which completed but with an error status.
It seems that you do not have enough checks on the different hooks. You should verify if the module is active and if the setup complete.