Code review about convermax

[nickolay-v]

Hi,
is there any way to let us know when module was installed?

[jnadaud]

Hi, if you need tracking to check if module is installed, please ask to your Partner manager for tracking rights in your initial deal.

Best regards

[Quetzacoalt91]

Here another comments and advices:

convermax.php

• install() : You should check first if curl is installed. If not, display an error return immediately false.
• removeTab(), You should test your variable $tab before removing it, it can be null.

classes/Cmssearch.php

• $fix should take care to use the https, if ssl is enabled on the shop.

controllers/admin/ConvermaxAdmin.php

• The parent class ModuleAdminController have a property $module. You should use in consequence:

$this->module->displayConfirmation(...);

and

$this->module->displayError(...);

[nickolay-v]

Hi, we fix it

[Quetzacoalt91]

Thanks a lot, we can close this issue and proceed with the security review

Best regards