prestashopcorp / convermax Goto Github PK

Hi,

some things you may change:

Readme.md file must be in uppercase
All index.php must use PrestaShop licence
Use public key in key folder never private
Please remove thumbs.db from views/img dir
Please consider use escape:UTF-8 also in template files

convermax.php:
289 - I think you want to use ShopName not ShoptName
284 - 301 - Tracking are not allowed
153 - You are using Media::addJsDef, your module will only be available from PrestaShop version 1.6.0.3

views/js/backoffice.js:
Google Analytics are not allowed
113 - You are changing PrestaShop backoffice location, please use window.open(url, _blank)

Everything is fine.

May be you could add some escaping in the following smarty template :

/convermax-master/views/templates/hook/facet.tpl:32

$facet->Values[0]->Term|regex_replace:"/ .*\]/":"" add |escape
$facet->Values[{$facet->Values|@count}-1]->Term|regex_replace:"/\[.*? /":"" add |escape

When I tried your module, many messages appeared on my screen.

During the registration process:

Or when I search an item without the index completed:

I also get Cross-Origin Request issues:

Hi,

config.xml file is missing, please consider add it.

Best regards

Hi,

Please place your files directly in repository not in convermax folder.

Best regards

Hi,

I quickly reviewed this module and saw overrides of Search functionalities from the PrestaShop core.
Please replace these overrides with classes, controllers etc.

I make this request because it can create conflicts on the shop if several modules try to override the same function. The rule applied will be first arrived, first served. So only one module will have the expected behavior, while the other ones will be broken.

When it will be done, I will be able to do a deeper review.

Regards

Please remove the link "Convermax search" from the side menu.

We do not allow this, because if each module try to add its own links, we would have too many button on this place.
However, you can use the configuration page of the module.