pret / pokefirered Goto Github PK

View Code? Open in Web Editor NEW

888.0 31.0 476.0 122.81 MB

Decompilation of Pokémon FireRed/LeafGreen

Makefile 0.41% Assembly 16.79% C++ 4.93% C 77.86% Shell 0.01%

pokemon decompilation gameboy-advance reverse-engineering c

pokefirered's Introduction

Pokémon FireRed and LeafGreen

This is a disassembly of Pokémon FireRed and LeafGreen.

It builds the following ROMs:

pokefirered.gba sha1: 41cb23d8dccc8ebd7c649cd8fbb58eeace6e2fdc
pokeleafgreen.gba sha1: 574fa542ffebb14be69902d1d36f1ec0a4afd71e
pokefirered_rev1.gba sha1: dd5945db9b930750cb39d00c84da8571feebf417
pokeleafgreen_rev1.gba sha1: 7862c67bdecbe21d1d69ce082ce34327e1c6ed5e

To set up the repository, see INSTALL.md.

For contacts and other pret projects, see pret.github.io.

pokefirered's People

Contributors

Stargazers

Watchers

Forkers

revosucks pikalaxalt camthesaxman aplumafreak500 shinysylveon04 felixjones rmer589 mother-of-dragons larrowhead missingmew sierraffinity doctorakimbo caleb9000 atasro2 xcameleonx meowsy fancycoconut luckytyphlosion xett pmarkive garakmon satomew tustin2121 abaresk ultima-soul rhatios16 chrisnguyen1403 flametix jiangzhengwenjz msikma gwimm jommg magical dfuchsgruber stand-user griffinrichards schmurtleburt kermalis geox123 ghoulslash youngstaa87 thundernerd louroboros mrgriffin kurausukun nxoxn adgonzalez97 thearcher1958 mightybirdy rmer4568 edfcsx gneiss-guy ledz96 shadow17993 chanbrown007 fieldy101 hal47 sam-hans0n sprunchkingaar achristensen6 neos21 elusiveillusion88 chillgg-hackers znogyrop fredd40 didgeridoomh sethbarberee deadpool205 git-afsantos eternalcode bigbahss deadaccountld waicalibre finalfakemon gispete pchaltv theleruby gitrman29 colorstheforce zmartis tylerchapman93 sharathhebbar yadunand buffaloburrow mixone-finallyhere ncorgan awesomeisfree pkmntrainerred20 ezwi123 charlesaverill wynought haruhisuzumiyah booshsource deokishisu scott-tt fserve hell-abhi colint evanbowman fouton

pokefirered's Issues

This code does nothing and cannot be right

https://github.com/pret/pokefirered/blob/1dd602d91495641448db8e4c711a5348b0316173/src/slot_machine.c#L1685C5-L1689C6

for (i = 0; i < NUM_PAYOUT_TYPES - 1; i++)
{
  if (rval < biasChances[i])
    break;
}

This code here will get stripped out by any compiler

Event flags (literally)

pokefirered/include/constants/flags.h

Lines 85 to 86 in e4acfdf

 #define FLAG_0x84A 0x84A 

 #define FLAG_0x84B 0x84B

are set by the appropriate DLC scripts after receiving, respectively, the MysticTicket and the AuroraTicket to enable processing of the appropriate item at the Vermilion dock;
0x2F0 and 2F1 record whether the matching introductory text has been seen!

Script Mapping for PlaySlotMachine is incorrect

pokefirered/data/script_cmd_table.inc

Line 141 in f93d5a8

.4byte ScrCmd_playslotmachine @ 0x8

IMHO it should be 0x89

Pokémon firered

cannot find -lc, -lgcc

I'm trying to compile fire red on a WSL2 Debian distro. I'm following the INSTALL.md
I have installed all the packages and setup DEVKITPRO, DEVKITARM variables correctly.

my windows version.

when I try to compile with make -j$(nproc)

Replace constant defines with Kanto-specific names

Specifically, location names and trainer class names

Drop reliance on agbsdk

Library sources should be newly assembled except libgcc and libc
Sys and library headers should be included from the iquote path

Add an install.md file

when install.md is open from the link on readme.md, it leaves you in a 404 error

deleting unused pokemon

in fire red theres 25 unused pokemon i wanna remove. how do i go about this. cuz its messing up my trainer rando alot.

Black 2 White 2 Disassembly

Hi, will you do a disassembly of black 2 and white 2?

How do I utilize the repository and the ROM I built in Ubuntu 18.04 LTS?

I believe I have a serious knowledge gap. I've been trying for weeks to run this provided build of FireRed, but I can't seem to get the program to run correctly. In Ubuntu, I've successfully built a repository for the game and a ROM to play the game. Then I used mednafen because I read a comment that said that works well. I got that going but whenever I input mednafen gba it gives me the specs and says it's starting but nothing happens. When I've tried to run my rom in the past, it returns "Cannot specify local host" or something like that. Obviously, I should've asked about this while I was doing it so all of this wouldn't currently be so foggy in my brain. Ultimately, my question is this: how do I play FireRed with my own builds, if it is possible?
...Upon reviewing my whole paragraph of a question, I also have another, related question. How do I navigate in Ubuntu or any CLI for that matter? This whole thing on mapping locations for files-- I'm super lost. Any help would be mundo mundo appreciated. Thank you for all you do.

Milestone: Decompile ASM to C

If you wish to contribute to this milestone, please join the Discord and claim a file from this list in #pokefirered.

Build fails on Ubuntu 22.04

Hello,

I'm trying to build the project using INSTALL.md but I get the error bellow.

sylvain@Ubuntu-22:~/Documents/pokefirered$ make compare
gcc -Wall -Wextra -Wno-switch -Werror -std=c11 -O2 main.c extended.c -o aif2pcm  -lm
gcc -Wall -Wextra -Werror -std=c11 -O2 bin2c.c -o bin2c 
gcc gbafix.c -o gbafix 
gcc -Wall -Wextra -Werror -Wno-sign-compare -std=c11 -O3 -flto -DPNG_SKIP_SETJMP_CHECK main.c convert_png.c gfx.c jasc_pal.c lz.c rl.c util.c font.c huff.c -o gbagfx  -lpng -lz
g++ -Wall -std=c++11 -O2 -I . jsonproc.cpp -o jsonproc 
g++ -Wall -std=c++11 -O2 json11.cpp mapjson.cpp -o mapjson 
g++ -std=c++11 -O2 -Wall -Wno-switch -Werror agb.cpp error.cpp main.cpp midi.cpp tables.cpp -o mid2agb 
g++ -std=c++11 -O2 -Wall -Wno-switch -Werror asm_file.cpp c_file.cpp charmap.cpp preproc.cpp string_parser.cpp utf8.cpp -o preproc 
g++ -std=c++11 -O2 -Wall -Wno-switch -Werror main.cpp sym_file.cpp elf.cpp -o ramscrgen 
gcc -Wall -Wextra -Werror -std=c11 -O2 -DPNG_SKIP_SETJMP_CHECK main.c convert_png.c util.c font.c -o rsfont  -lpng -lz
g++ -Wall -Werror -std=c++11 -O2 scaninc.cpp c_file.cpp asm_file.cpp source_file.cpp -o scaninc 
tools/ramscrgen/ramscrgen .bss sym_bss.txt ENGLISH > build/firered/sym_bss.ld
In file included from src/agb_flash_1m.c:1:
include/gba/gba.h:4:10: fatal error: string.h: Aucun fichier ou dossier de ce type
    4 | #include <string.h>
      |          ^~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:275 : build/firered/src/agb_flash_1m.o] Erreur 1
make: *** [Makefile:195 : compare] Erreur 2

Seems like wrong compiler is used or compiler not installed correctly?

I installed gcc-arm-none-eabi by my side hoping it would solve the issue but it did not ;)

Thanks in advance :)

Wrong Songs in FireRed

Hello , i just recently came across your blog and in the end , here, because i wanted to hack some pokemon game rom's so i can make my own custom changes and also go even a little deeper.

So, while i came across your blog, i also have came across the FireRed and LeafGreen source codes, which is awesome, but while i was checking them , i realised that the folder with the Songs, has the wrong music , is not the music from FireRed/LeafGreen, but Emerald.

Could you check and upload the corect Songs ? , if you still got the Source Codes.
But either way , is fine, i mostly took the source code to see how it's writen, and to see the scripting part, because i want to custom that but i don't understand it very well yet.

Thanks.

Removing cut trees in viridian city breaks tutorial man

To recreate:
Remove either or both of the cut tree objects in ~/pokefirered/data/maps/ViridianCity/map.json, making no other changes to the file. Rebuild (currently using leafgreen 1.1, unsure if the issue occurs in other builds). the old man will move ~5 tiles up from his original position and the woman typically next to him will take his place. unaware if this issue occurs beyond the coffee event.

make -jX not working with LeafGreen

When using the -j parameter with "make leafgreen", I'm getting the following make warning about it using -j1.
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.

This does not appear when just using "make -j16" for FireRed. Therefore, building LeafGreen is way slower.

German FireRed ROM disassembly

Hi, does a disassembly of FireRed exist in German? Thanks!

Porymap Support

Now that Fire Red is free of baserom calls, we need to make this a priority somewhere.

decompile event object movement data
layout 21 is missing field(s)

Colorizing PNGs

Some .png files are still grayscale, others have a single palette applied incorrectly to all tiles.
Have an in-progress branch for this, but may submit some of it piecemeal. Feel free to comment with images missing from the list (map tileset images intentionally excluded)

Editing maps layout and rebuilding doesn't update map

To recreate:
Edit any map layout (~/pokefirered/data/layouts/*/map.bin)
Rebuild as leafgreen 1.1 (unsure if it happens with other builds). clearing existing built files or using NODEP=1 argument does not affect the outcome
Reload the map ingame. exiting and reentering the area reveals it does not update (i am aware that the map is stored in the save file and needs to be reloaded by reentering).

Typo in define for pokemon_summary_screen.c

at line 2536 the define for GetMovePpPinterYpos has a typo.

It's missing the "r" it should be GetMovePpPrinterYpos

I apologize for not sending a pr, as is typical,
but I'm not accustomed to working in git, and the repo I'm working in
has substantial changes.

It'd prob be easier for ya'll to just rename the file on your end than try to merge mine.

pret / pokefirered Goto Github PK

pokefirered's Introduction

Pokémon FireRed and LeafGreen

pokefirered's People

Contributors

Stargazers

Watchers

Forkers

pokefirered's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs