GithubHelp home page GithubHelp logo

bluemountainsprings's People

Contributors

cwulfman avatar waffle-iron avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

Forkers

cwulfman jpstroop

bluemountainsprings's Issues

expand error handling

To the maximum extent possible, the API should perform error checking on requests, and should always return a meaningful status, either with the resulting data or an indication that the request was invalid or that the data was not available.

Support parameter query string option to control output format

It would be convenient to add a request parameter that would allow users to specify the format they want. This would make it easy for users to explore the API via browser without having to use curl or other scripted tools, and would also make it possible to link directly to a particular result, which could be helpful in demonstrating using the API output with other tools.

schedule code review

Brian Kernighan will direct a Code Review of the Blue Mountain Springs Code Base.

Prepare the narrative description

2-3 pages,

Describe goals reached, and both scholarly and technological outcomes of the project.

Briefly describe the public-facing outcome of your CDH grant year. If this includes a website, provide a link to the website.

Explain major changes and discrepancies with planned work.

Review and update (if necessary) your project blurb on the CDH website. Provide a link to your public-facing research outcome and data repository.

IIIF Manifest metadata not properly formed

Shaune points out

{
"title": "Action: cahiers individualistes de philosophie et d'art"
}

should be:

{
"label": "title",
"value": "Action: cahiers individualistes de philosophie et d'art"
}

enhance documentation in GitHub repo

The Github repository should include at least links to all BMS documents so that there is a single reference point from which every public project document can be accessed. It is left to your discretion whether existing documents are imported or left as is on other servers.

Default return format

The default return format should be consistent when no accept header is specified. Seems to default to csv in some cases, json in others, and tei in others. If there is not a common format available for all API requests, then include that in the documentation and explain the order of precedence of the default return format based on what formats are available for a given API request.

Support HTTP HEAD requests

The last time I checked, this returned a 404 Not Supported.

HEAD request support would be helpful for people investigating the API to see what formats are accepted, etc.

Update project blurb on CDH website

Review and update (if necessary) your project blurb on the CDH website. Provide a link to your public-facing research outcome and data repository.

finalize data repository

Provide an open-access copy of your data, with a brief readme file with a brief description of the data, structure/organization, and data types.

  • complete metadata cleanup
  • generate all derivatives
  • write README file

Install instructions not easily readable online

The installing.html file referenced in the README provides useful installation instructions, but is not easily readable on GitHub. I recommend including it in the GitHub pages site and then linking directly to the current version from the readme. (Alternatively, you could convert the installation instructions to markdown for easy display on GitHub directly.)

Might be nice to link to exist documentation on the package manager, for anyone who needs more info/help on installing package dependencies.

Also consider adding a link to the github pages site more generally.

finalize code repository

  • Complete APIs

Generate readme file containing the following:
1-2 paragraph description of project
link to cdh website and any other public-facing project website
description of repository organization
installation and dependency information or instructions
any known issues or customization points

expand tutorial material

The API documentation should be expanded to include more examples of searches and queries that users might want to perform; in effect, these are additions to the tutorial material. BMS has only a small user population at this point, so it is difficult to speculate about what kinds of searches might be representative. Your additions should cover a reasonable spectrum of possibilities, but need not be exhaustive.

The examples should include a complete instance of how to connect the results of a BMS query to Voyant, and an instance showing how to connect to Palladio, as representatives of widely used DH systems.

The examples should also include at least one instance of using the API to query BMS from a standard programming language like Ruby or Python, parsing the resulting JSON or XML and performing some analysis or reformatting on it.

All examples must have been tested and must work as shown.

Error handling - 404 when id or api endpoint is not found

On my initial tests, API requests returned 500 errors when no data was loaded; it should have error handling throughout.

  • magazines/id should return a 404 Not Found when the referenced id is not found
  • issues/id should return a 404 Not Found when the referenced id is not found

Any other API endpoints that reference ids should return 404s if the id is not found in the loaded data.

Any requested URL that doesn't match a valid API endpoint should return a 404.

expand testing

Expand testsprings.rb to do a more exhaustive walk of the resource.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.