privacysandbox / coordinator-services-and-shared-libraries Goto Github PK

AWS provider default_tags settings don't work if specified from the environment main.tf settings (./terraform/aggregation-service/environments/ENVIRONMENT_NAME/main.tf)

It looks like the AWS provider configured in the ./terraform/aggregation-service/applications/operator-service/main.tf is blocking default tags to propagate on all resources

I tried to host resources in the already configured VPC and got the following errors:

│ Error: Invalid index
│
│   on ../../../../submodules/coordinator-services-and-shared-libraries/operator/terraform/aws/applications/operator-service/main.tf line 205, in module "worker_service":
│  205:   dynamodb_vpc_endpoint_id = module.vpc[0].dynamodb_vpc_endpoint_id
│     ├────────────────
│     │ module.vpc is empty tuple
│
│ The given key does not identify an element in this collection value: the collection has no elements.
╵
╷
│ Error: Invalid index
│
│   on ../../../../submodules/coordinator-services-and-shared-libraries/operator/terraform/aws/applications/operator-service/main.tf line 206, in module "worker_service":
│  206:   s3_vpc_endpoint_id       = module.vpc[0].s3_vpc_endpoint_id
│     ├────────────────
│     │ module.vpc is empty tuple
│
│ The given key does not identify an element in this collection value: the collection has no elements.

How to reproduce

Specify the following variables:

enable_user_provided_vpc = true
user_provided_vpc_subnet_ids = ["subnet-todo1", "subnet-todo2"]
user_provided_vpc_security_group_ids = ["sg-todo3"]

Looks like the worker_service module tried to use internal VPC even if I configured it to not do that

We (Google Ads) use a different security model for deploy production changes and do not wish to instantiate a deploy service account with token based authentication as this is not compatible with our security policies.

Our automation/deploy users are already instantiated and granted sufficient roles to perform all the actions in the deploy role.

Can we make it optional to instantiate the deploy account AND all of the downstream roles, iam, serviceTokenCreator iam?

PR with suggested changes incoming shortly