profforgr / googchart Goto Github PK

What steps will reproduce the problem?
1. Put "big" amount of data in the $data array. In this case, some 22 items.
2. Draw the pie chat and the vertical bar chart

What is the expected output? What do you see instead?
The pie chart is OK, but the vertical bar chart is not. In the X axis, not
all the items are painted, just 12 of the 22.

What version of the product are you using? On what operating system?
V0.1, Windows 7

Please provide any additional information below.
Also, when the words are big in length, in the vertical bar chart,
sometimes they are overlapped, so it's difficult to read.
I attach the photo of the pie graph and the vertical bar chart, to see the
information.

PD:
I added the following line codes to change the range of the charts.
(http://www.wdvl.com/Authoring/PHP/GoogleChartAPI/Jason_Gilmore01192010.html) 

http://chart.apis.google.com/chart?cht=p&chtt=Fetcher+Status&chd=t%3A174%2C12402
84%2C692475%2C601965&chl=STATUS200%7CSTATUS404%7CSTATUS302%7CTIMEOUT&chs=400x300
&chco=99C754%2C54C7C5%2C999999&chm=&chf=a%2Cs%2Cffffff

4 parts have the same persent?

What steps will reproduce the problem?
1. bar data where the min > 0
2.
3.

What is the expected output? What do you see instead?
You get a bar graph with your lowest value on the x-axis, making it appear 
to a user that it is, in fact, 0

What version of the product are you using? On what operating system?


Please provide any additional information below.

This modification fixes the problem:

search for chds and replace the line with the following code:

'chds' => ($this->min != $this->max) ? min(0,$this->min).','.$this->max : 
null, // Data scale

What steps will reproduce the problem?
1. Insert the data in the array of data: if a data has any -of all- of the
followings it will not print the names of the data in the pie. Never the
less, it will draw it WITHOUT the names. The characters are: ñ, á, é, í, ó,
ú, this is, usual characters in Latin languages -spanish for ñ and the
others, frech, italian, etc. for the accents. 
2. Run the script
3.

What is the expected output? What do you see instead?
I expect the pie chart with the names. The current output is the pie chart
without the names indicating each portion,

What version of the product are you using? On what operating system?
V.0.1. Windows 7

Please provide any additional information below.
Example:
$data = array(
            'ávalon' => 22,
            'hello' => 30.7,
            'ñoqui:)' => 1.7,
            'works' => 36.5,
        );

a

What steps will reproduce the problem?
1. Take first Pie Chart example, and remove all but two elements.
2. Set both their values to "1"
3. Data:

$data = array(
                        'IE7' => 1,
                        'IE6' => 1
                );

What is the expected output? What do you see instead?
A pie chart with 1/2 IE7, 1/2 IE6

What version of the product are you using? On what operating system?
Windows XP (virtualized), PHP 5.2.6, IIS

There are 2 major issues:
- data types should be enforced (integers/floats casted with (int)/(float))
  Example:
    $this->size[] = $width;
  Should be:
    $this->size[] = (int)$width; // or at least (float)
- Image output be properly encoded, otherwise HTML could leak out.
  Example:
    return sprintf('<img src="%s" alt="%s" style="width:%spx;height:%spx;" />', $url, $alt, $this->size[0], $this->size[1]);
  Should be:
    return sprintf('<img src="%s" alt="%s" style="width:%spx;height:%spx;" />', htmlspecialchars($url,ENT_QUOTES), htmlspecialchars($alt,ENT_QUOTES), $this->size[0], $this->size[1]);


Careless users might not know about the above issues and not sanitize input 
themselves:
$chart=new GoogChart();
$chart->setSize($_REQUEST['w'],$_REQUEST['h']); // <- vulnerable

Nice job on the chart, very simple and easy to use.

Christian Sciberras.

What steps will reproduce the problem?
1. values superior a 100

What is the expected output? What do you see instead?
if i have values less that 100 my chart is correct

What version of the product are you using? On what operating system?
0.1 on windows 7

Please provide any additional information below.

What steps will reproduce the problem?
1. Run the example program with Apache 2.0 on linux
2.
3.

What is the expected output? What do you see instead?
No output

What version of the product are you using? On what operating system?
Current, CentOS 4.7

Please provide any additional information below.
Here is the error message the Apache log file leaves.

[client xx.71.209.206] PHP Parse error:  parse error, unexpected T_CONST,
expecting T_OLD_FUNCTION or T_FUNCTION or T_VAR or '}' in
/var/www/html/GoogChart.class.php on line 36