projectblacklight / blacklight-locale_picker Goto Github PK

For what it's worth, I tried adding this to a rails 6 app, and it seems to be working okay with no changes needed (except to the .gemspec file).

This was initially implemented as <span class="sr-only"><%= t('blacklight.toolbar.language_switch') %></span>, but we don't have translations for this yet.

What's the target string for this menu, @ggeisler @jvine ? "Change language"? "Language" might be slightly easier to source translations for because it doesn't have a verb.

Should this be an aria-label on the ul instead? An example is language picker on if-me.org

The dropdown currently has the "menu" role. According to the ARIA standard, elements with the "menu" role need to have child elements with the menuitem role.

I am not an accessibility expert, but I am not sure the "menu" role is even the best fit for the dropdown, so the best option might be to just remove that role.

Part of projectblacklight/arclight#544

When running Arclight, the application errors because of the following syntax error

s/blacklight-locale_picker-0.1.0/app/helpers/blacklight/locale_picker/locale_helper.rb:17: syntax error, unexpected keyword_rescue, expecting keyword_end (SyntaxError)
    rescue ActionController::UrlGenerati
          ^
/Users/nikitas/.rvm/gems/ruby-2.4.4/gems/blacklight-locale_picker-0.1.0/app/helpers/blacklight/locale_picker/locale_helper.rb:17: syntax error, unexpected =>
troller::UrlGenerationError => e