prokopst / talkative Goto Github PK

It might be useful to support JSON.

It's perhaps better to use more generic Data element than two specific Text and Audio.

So instead of:

<Speeches>
    <Speech lang="en-US">
        <Text>What do you want?</Text>
        <Audio>audios/what_want.wav</Audio>
    </Speech>
</Speeches>

will be:

<Speeches>
    <Speech lang="en-US">
        <Data type="text">What do you want?</Data>
        <Data type="audio">audios/what_want.wav</Data>
    </Speech>
</Speeches>

The benefits of this approach is that users can use their own data like path to movement of a head, etc.

XML serialization logic is tighly coupled to core elements. XML serialization should be decoupled, preferably as separate library (Talkative.Xml?).

Outcome

• IConversationFormatter interface accepted by ConversationFactory for loading/saving conversations, XmlConversationFormatter class created to load from/save to XML
• Talkative.Core namespace has no XML
• removed dependency to System.Xml from Talkative
• separate library Talkative.Xml

• accept parameter maxCachedCount with implicit parameter to 0, save it as a public property MaxCachedCount
• public PreloadConversation methods for all LoadConversation overloads
• public ClearCache method to clean whole cache
• change LoadConversation to handle loading from cache, moving fresh conversation to top and removing old items
• tests