Comments (3)
Sure.
Iter
The primary problem I have found when using this library is that without knowing all the label keys, it's not possible (please let me know if it is) to get any metrics.
Suppose I have an application that requires me to spawn n
components to process some workload. At runtime each of these will be spawned and assigned a uuid. In order to monitor these I would like to attach a metrics counter to each (using uuid as the primary label field). I will create a Family<ComponentLabel, Counter>
for this.
Now suppose I am now in some other part of the application and would like to iterate over every metric in that family. The only way to do this at the moment (i believe) would be to store a vec of uuids that you inserted into the family and manually iterate over each and get_or_create()
.
The family "hashmap" is already storing all the data we need to iterate over it, but doesn't expose any functionality to interact with it (outside of get_or_create
). Requiring a separate data structure to store insertions for later seems wasteful and unessesary.
Clone
Using the above example, suppose I want to compare metrics of each component over time. To do this, I would like to take a snapshot of the metric family at time t
and then some time later in the processing take another snapshot and then compare the two. This may be used for example to see if the processing is lagging (counters are not increasing).
This is not possible at the moment as M
(in `Family<S,M>) is not clone and the underlying family hashmap isn't exposed.
Suggestion
To solve both these problems I suggest making M
clone (in Family<S,M>
) and exposing the read method of family.metrics
.
E.g. in metrics/family.rs
:
pub fn read(&self) -> RwLockReadGuard<HashMap<S, M>> {
self.metrics.read()
}
This would solve both these problems and allow a user to do something like:
family .read().iter() .map(|(label, counter)| { do_something() })
Also providing a snapshot()
method on the registry,family or metrics would be nice. This should be easy to implement and give user's a nice interface to compare metrics over time.
from client_rust.
Can you expand on the use-cases that you want to solve with the above proposed changes?
from client_rust.
I am also looking for these features.
My use case is to expose some metrics and labels, via a proprietary endpoint in addition to the standard /metrics
endpoint. Currently I have to store the inserted labels in a HashSet
which seems unnecesary.
from client_rust.
Related Issues (20)
- Allow flattening of a struct through derive(EncodeLabelSet) at any position HOT 2
- Make `Descriptor::new` `const` HOT 1
- feat: derive register logic on struct of metrics
- Allow multiple labels in sub_registry_with_label method HOT 2
- Allow root registry creation with prefix AND label(s) HOT 1
- Implement native histograms HOT 1
- Escaping? HOT 3
- Public encoding functions? HOT 4
- Encoder without EOF HOT 5
- Custom Collector with `sub_registry_with_prefix` outputs name multiple times HOT 3
- Abstract key lookup into a trait for Family::get_or_create HOT 4
- Allow iterating the metrics on an registry HOT 1
- Allow construct a histogram family with a closure HOT 2
- mips: EncodeCounterValue implementation missing for u32?
- Histogram with empty family labels creates unparseable metrics output HOT 1
- text::DescriptorEncoder writes incorrect metric names HOT 2
- UTF-8: Implement support in Rust client library
- Implement Atomic for usize HOT 2
- Counter `HELP` and `TYPE` lack `_total` suffix HOT 5
- Provide a way to prevent unbounded metric growth HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client_rust.