GithubHelp home page GithubHelp logo

Comments (5)

mxinden avatar mxinden commented on May 25, 2024

Correct. Histogram does not implement Default. As you mention above, this is due to not knowing what the buckets should be by default.

from client_rust.

doehyunbaek avatar doehyunbaek commented on May 25, 2024

Maybe add default as in client_golang as it is the most popular client implementation?

https://github.com/prometheus/client_golang/blob/66837e3298bdc57a828794c23bacb253ed8c04cd/prometheus/histogram.go#L68

I can contribute a PR as it seems not too hard if you agree.

from client_rust.

hiuwan avatar hiuwan commented on May 25, 2024

yes, we can refer to the client_golang and client_java to provide default buckets.

from client_rust.

mxinden avatar mxinden commented on May 25, 2024

I would rather call this out in the documentation on Histogram, providing an example with the above mentioned default values. I am not in favor of adding a Default implementation that only works for some use-cases, here network latency measurements. I find this confusing for newcomers. Experts will be familiar enough to read the example and thus configure it themselves.

I can contribute a PR as it seems not too hard if you agree.

Improvements to the documentation would be appreciated.

from client_rust.

mxinden avatar mxinden commented on May 25, 2024

With #63 merged, I am closing here. Feel free to follow up with further comments.

from client_rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.