Appveyor PR builds failing about matterhook.net.matterhookclient

[rgomez90]

So, I think I`ve solved this, but I'm not really if I know why/how 😄

I`ve made a new fork of the project and new project in (my) appveyor to make test.

After a while in Appveyor's project configuration site I saw this

Since I am reaaaally very new to CI, I don't really know much about that, but I guess when activating this option, (like image says) a random string is appended to the build version number.
The file numbers MUST BE numbers and must be able to be stored (afaik) in an uint (look here).

So my guess is this option creates an UNVALID version number and is setted to the version variable in appveyor.yml.

I disabled the option and it builds on pr as well, so I think that's the issue.

If so, with my little knowledege about CI, I guess we have 2 options:

• Disable it
• Remove this "random" string somewhere before building

But I am sure there are more "sofisticated" (😄) ways of doing this...

In my "little investigation" I noticed a few "strange" things (I dont say bugs since I dont really know as said about CI).

• The artifact built with this configuration was a package ending in 1.0.0 (hmmm?) it was build Nr. 6, so it should be 1.0.6?

• It should not be 1.3.6 instead of 1.0.6?

• When taking a look into the created DLL with the Nuget Package Explorer I noticed:

  • Wrong version as well
    

  • Wrong version numbers in created dlls
    .

[PromoFaux]

Honestly I don't think I ever did the versioning correctly on this project. In the old days I'd just bump the version in assemblyinfo.cs, I'm a bit new to the dotnet core way of doing things!

[PromoFaux]

Fixed in #15