prontolabs / pronto-foodcritic Goto Github PK

Hi @mmozuras,

I tried to install ALL the runners just to see what would happen. I had to uninstall pronto-foodcritic because of the below conflict (also had to uninstall pronto-spell and pronto-fasterer for the same reason).

.rvm/rubies/ruby-2.1.4/lib/ruby/site_ruby/2.1.0/rubygems/specification.rb:2112:in `raise_if_conflicts': Unable to activate pronto-spell-0.4.1, because pronto-0.5.3 conflicts with pronto (~> 0.4.0) (Gem::ConflictError)

Is a fix for this as simple as updating the .gemspec file to ~>0.5.0?

Hi @mmozuras,

First off thanks for the useful gem and the bunch of integration provided.

While installing all the runners, I noticed two of them (pronto-jscs and pronto-rails_schema) require an older version of pronto which seems to conflict with the latest version installed 0.6.0.

/Users/eric/.rbenv/versions/2.2.2/lib/ruby/site_ruby/2.2.0/rubygems/specification.rb:2288:in `raise_if_conflicts': Unable to activate pronto-brakeman-0.6.0, because pronto-0.5.3 conflicts with pronto (~> 0.6.0) (Gem::ConflictError)

gem dependency -R pronto

Gem pronto-jscs-0.0.5
  bundler (~> 1.10, development)
  pronto (~> 0.5.0)
  rake (~> 10.0, development)
  rspec (~> 3.3, development)
  rspec-its (~> 1.2, development)

Gem pronto-rails_schema-0.5.0
  bundler (~> 1.10, development)
  pronto (~> 0.5.0)
  rake (~> 10.0, development)
  rspec (~> 3.3, development)

Right now it seems that the runner is built for chef repo's which contain multiple cookbooks (or roles) as https://github.com/mmozuras/pronto-foodcritic/blob/master/lib/pronto/foodcritic.rb#L35 expects the path to include cookbook.

However when all your cookbooks are separated into single repositories cookbook might not always appear in the path. For example when your repository name does not include -cookbook or when you're running it on a CI server which does not use project names internally (like GitLab CI).

I'd say to remove that check alltogether and just run foodcritic on all files. Does that sound reasonable to you?