provesource / official-gtm-tag Goto Github PK

Your template has been approved and should appear in the Template Gallery shortly. A few recommendations:

1. each tag should return data.gtmOnSuccess or data.gtmOnFailure once during execution. On line 59 of template.tpl the else clause should call one of the other.

// Inject the tracking Script into the Page
if (query('inject_script', scriptUrl)) {
  log('Injecting ProveSource script with key', apiKey);
  injectScript(scriptUrl, data.gtmOnSuccess,data.gtmOnFailure);
}else{
  log('No permission to inject script');
}

2. On line 53 of template.tpl, all user provided values used in a URL should be URI Encoded. You can use encodeUriComponent() on apiKey to ensure the url generated is valid

// Build the Script URL
const scriptUrl = 'https://cdn.provesrc.com/provesrc.js?apiKey='+apiKey;