GithubHelp home page GithubHelp logo

Comments (8)

toniblyx avatar toniblyx commented on May 14, 2024

Thanks @virtualjj, as you say there I didn't find a query to figure out if hardware MFA is used so I queried for just MFA which is also good and pretty valid check. I'm fixing it now as you suggest and also adding a comment to clarify that, in case of OK, it is Virtual MFA.

from prowler.

toniblyx avatar toniblyx commented on May 14, 2024

as you say, running:
aws iam get-account-summary | grep MFA

I get:
"MFADevicesInUse": 1,
"MFADevices": 1,
"AccountMFAEnabled": 1,

In my case is also use virtual MFA, so no way to see if it is hw or not.

from prowler.

virtualjj avatar virtualjj commented on May 14, 2024

Cool - I raised a support request with AWS to see if there is a workaround for this and will update as soon as I get an answer.

Thanks again for this very helpful project!

from prowler.

toniblyx avatar toniblyx commented on May 14, 2024

Thanks @virtualjj I will also go ahead and change the check command with this one which seems to be more accurate despite we don't know if it is HW or SW: aws iam get-account-summary |grep AccountMFAEnabled | awk -F":\ " '{ print $2 }'|sed 's/,//'

from prowler.

toniblyx avatar toniblyx commented on May 14, 2024

@virtualjj just commited the change, I have tested it in two accounts and it works. You can test it now. Glad you find it helpful.

from prowler.

virtualjj avatar virtualjj commented on May 14, 2024

Tested and confirmed:

image

I think this is a reasonable message since the hardware MFAs listed as supported by AWS have synchronization issues which isn't worth the trouble in my opinion.

I did receive a reply from AWS support that root MFA API / CLI calls are limited for security reasons citing this resource:

http://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_mfa_enable_cliapi.html

The workaround proposed by AWS support requires having paid support for Trusted Advisor and these commands that I wasn't able to test since my dev AWS account doesn't have paid support:

sudo yum install jq

check_id=$(aws support describe-trusted-advisor-checks --language en --region us-east-1 | jq -r '.checks[] | select(.name == "MFA on Root Account") | .id')

aws support describe-trusted-advisor-check-result --check-id "$check_id" --region us-east-1 | jq -r '.result.status'

from prowler.

toniblyx avatar toniblyx commented on May 14, 2024

I have checked those commands with one of our paid support accounts and I don't think it adds more value or information to what I currently have with the existing check. Another reason to write prowler was to not to depend on your support status to get good advises about security. Thanks for your time looking at it @virtualjj

from prowler.

virtualjj avatar virtualjj commented on May 14, 2024

Awesome and agreed - thanks again!

from prowler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.