psalaets / excel-formula-ast Goto Github PK

If you pass a malformed formula to the library, it will be stuck in a loop.

For example:

const tokens=tokenize('SUM(')
const rootNode = buildTree(tokens)

I am not sure if this belongs to the tokenizer or the excel-formula-ast. If you are in german excel, you need to use ";" as separator for function arguments. "," is used for numbers.

=WENN(WAHR;1,1;1,2)

I'd love to see typescript support for this library.

In german excel, you have 'WAHR' and 'FALSCH' instead of 'TRUE' and 'FALSE'. The library will output a logicalNode only if the name is 'TRUE' or 'FALSE'. 'WAHR' and 'FALSCH' will be handled as 'cell'-Node. I am not sure if this is a lower-level (tokenizer) or ast problem.

It is easy to work around, but I think this could be handled better, e.g. a list of names for logical true, and a list of strings for logical false. I don't have any idea what this looks like in spanish, for example.

the nodes do not have a corresponding token attached, therefore it is difficult to see where an error is in the original formula. I'd like to have linting for excel formulas (codemirror), but for it to work it needs line/column marks to where something is wrong (e.g., unknown cell range or unknown formula)

Hey guys,

You are doing an awesome work to generate AST representation of excel formulas. It is a hardwork and I would like to thank you guys for it.

I just wanted to ask what is current status of the project? Is it still in active development phase, or it has reached to alpha/beta/stable phase? How much excel formulae it has supported until now? I guess https://github.com/psalaets/excel-formula-tokenizer is also closely related to this project and will be almost on the same stage.

Best regards

Hi Alex,

I've been evaluating a number of excel formula parsers (including writing my own) for a project I'm working on, when I discovered your parser.

The design of the AST builder is elegant and I'm wondering if you're open to contributions to the excel-formula-ast and excel-formula-tokenizer? Also, is github's issues the best way to reach you?

Thanks!