pslawski / np-java-sdk Goto Github PK

In most cases, the errors thrown by the server should be handled. For example, WithdrawLimitException should be a checked exception.

I'm not sure if IOExceptions should be wrapped in an unchecked exception when at the boundary between this library's code and its users. (e.g. methods such as collectInterest from the NeopetsBank interface.

It is desirable to minimize the number of logins made by the clients. An account credentials should be paired with a cookie file to:

• share sessions between different clients, example, NeopetsBankClient and StockMarketClient in the same execution.
• share sessions between different executions of the programs using this library.

If the cookies stored in the cookie file are valid, then the corresponding account credentials are not needed until the session expires. Thus, in a way, the cookie file is a valid form of credentials.

Hey Peter, this is John. Do you mind checking your email/phone/facebook? It's hard to get a hold of you. @pslawski

Results objects such as BankRecordsResults should be POJOs. The parsing logic of the response contents should be extracted into a Parser class. In this example, BankRecordsParser.