psliwa / fluent-traversable Goto Github PK

The name of FluentComposer::forArray is misleading because it does not only accept arrays but also Traversable. I would expect a type hint array for the parameter.

FluentComposer::forValue should assert that a value has been passed instead of hiding the wrong call by using no values [] (source).

Further, a non-strict version FluentComposer::forIterable or FluentComposer::forTraversable might be added.

the iterable pseudo-type [...] is an array or an object implementing Traversable
see http://php.net/manual/en/function.is-iterable.php

is_iterable (introduced in PHP 7) is similar to FluentTraversable::isTraversable. Since the term Traversable is used for different types (built-in Traversable vs. FluentTraversable) FluentComposer::forIterable might be more accurate than FluentComposer::forTraversable.
Actually, FluentTraversable::from accepts also FluentTraversable which is not an Iterable but that could be fixed by implementing IteratorAggregate or Iterator.

like traversing a data-tree? say objects with children properties.

As title, this package still supports the old php-5.x versions.

It's time to bump into php-7.x versions because the php-7.0 version has been released for about three years.

@psliwa, what do you think about this issue?

Is there something against releasing version 1.0.0 (see How do I know when to release 1.0.0?)?

Hi,

I am new in PHP and I want to use your great library in my project, but i can't use composer. Did you explain how to use in other means?