punishxiv / artisan

A 'simple' crafting plugin.

Crafting Automation Plugin/Helper for FFXIV

Repo Url:

https://love.puni.sh/ment.json

artisan's Issues

Add an option to "Add to New Crafting List" in the crafting log

Right now you can "Add to Current Crafting List" or "Add to Current Crafting List (with Sub-crafts)" from the crafting log. What I really seem to need most is the ability to add an item to a NEW crafting list.

Thanks for reading!

Problem with CN-Dalamud api

CN api is still api8. Because of the api upgrade, CN cannot use Plugins in PunishXIV anymore.

Feature Request: Toggle for pulling HQ mats from retainer

Not a huge deal, but figured I would request this in case it was a simple addition.

At the moment, the default functionality of the button under Crafting Lists "Restock Inventory From Retainers" will prefer to pull HQ materials instead of NQ ones. This requires me to manually pull those out every time to get NQ ones.

Use: I have NO reason to use HQ mats on a lvl 83 craft, and this would simply save some time and effort.

Load error after updating to v3.0.5.0

Hi, I got this error after updating to the latest version. The patch of my game is CN 6.50.

Feature Request: Expansion of Previous Request "Export remaining ingredients list as plain text #52"

Would it be possible to add on to this to export the list with other data as well, like the other headers, maybe this could be an option and maybe which header from the ingredient list we want exported with can be an option as well, maybe as a CSV or Json (also could be option)

could this all be done from the command line as well,

ex
/artisan exportingredients -remainingonly -clipboardjson -headers required,source,gatheredzone

also would it be possible to somehow make a List that could be read from other plugins vs exporting to the clipboard? or a string formatted as json? (maybe also an option -ipclist or -ipcjson)

Auto Action Mode not continuing after first action.

Just something I have experienced recently; whenever I am mass crafting, Auto Action Mode does the first action of a macro and then stops. I have to manually toggle AAM off and then back on to get it to continue the macro for the craft.

However if I leave it to use recommended actions or the new Expert Recipe Solver mode, it will work as intended. Just macros are bugging out AAM for me.

Standard Solver logic gridlock

Under certain circumstances during a craft, the Standard Solver will stall and fail to perform the recommended action or any actions at all, causing the character to indefinitely idle at the craft until player intervention.

I've observed this happening only when all of the following circumstances are met:

• The "condition" of the craft is "Good" or "Excellent"
• The "durability" state of the craft is low (only observed at 10 durability but presumably any value under the threshold would suffice)
• The character's crafter level is less than 13 (ie. the action "Tricks of the Trade" is not available)

(I'd speculate that this is due to a missing availability check for TricksOfTrade somewhere, maybe in Solve(), but I should note I haven't tried applying any fixes myself yet.)

Edit: The expected behavior in these circumstances would be to use "Master's Mend" or some progress-increasing ability to complete the craft, under the assumption that these would be preferable to failing the craft

Opening Artisan greys screen, unable to click

If I open the main Artisan Window, my entire screen goes slightly grey and my mouse is unable to click on anything in the UI.

This occurs both in-game or at the main window. Both with the /artisan command, or opening through Dalamud trigger the error. Windowed, borderless windowed and full-screen game mode are equally effected. The resolution I play at does not change this behavior.

I am able to quit the game using keyboard shortcuts, but am unable to quit Artisan. Logging out does not fix the issue, only a full quit of the game does.

I have disabled all other plugins, and restarted the game. The issue still occurs.

Only the main Artisan settings window causes this effect. The side-window on the crafting log appears fine and crafts function correctly.

I am using Artisan v2.1.0.10 and Dalamud D9.0.0.2

Normal UI

Normal UI, Artisan Opened

Main Menu

Main Menu, Artisan Opened

kawaii's list of enhancements

I will handle these at one point or another;

• ability to rename macros in the macro list
• nested directory support in the macro list
• split progress and quality upgrade options for macros
• small button to quickly open the settings menu from the crafting menu (font awesome gear/cog)
• automatic spiritbonded gear materia extraction

Feature: Required consumables for macros

It is currently only for Crafting Lists or Endurance mode right now. But it would make more sense to have it for your macros instead, or both.

Current workflow right now if I wanna wake alot of one item that requires a tincture and food. Then I either have to go into settings, and enable, required consumables(and remember to turn it off), or I have to make a crafting list with that item and add it as many times I intend to craft it and there I can add required food/tincture.

But when you make macros you always have a certain consumable combination in mind. So it makes sense to have it there instead. Then I could just open the Crafting menu and click the Endurance mode button and it starts crafting, and the Macro makes sure I have the required consumables.

Standard Solver Concern

Noticed the standard solver is incredibly worse than a prebuilt macro, it's even skipping usage of great strides/byregots in some cases. Is this standard behavior or is there an issue?

Bug: Adding a recipe with a quantity to an empty list changes that recipe's quantity in other lists

Reproduction:

• If you make a list (e.g. Food (up to 99)),
• add a recipe with sub-crafts with a quantity (e.g. Baked Eggplant x 33),
• make a new list by cloning that list (e.g. Food (up to 180)),
• delete the items in the list,
• add a recipe with sub-crafts with a quantity (e.g. Baked Eggplant x 60)

Then both lists will have the steps in it generated by the final step: crafting Baked Eggplant 60 times

The only way around this is to perform these steps in one of the list:

• delete the sub-crafts
• set the quantity of the main recipe to 1
• add the recipe with sub-crafts with a quantity
• reduce the main recipe by 1

Basically, you must leave behind a step, and if you don't then it edits The Original List + All Lists Cloned From It.

I suspect this has to do with the title for a list only appearing in the List Editor if you have a step in the list, and if you don't have any steps it appears that adding to the list defaults to a name for the list that is not being updated when you edit the name and is copied from The Original List, and that all Copied Lists still have in them.

How do i reset the plugin configuration to the default settings?

Like, is there a button to press?
I uninstalled then reinstalled the plugin but it still retained my configuartions

Updated the issue but still can't open the running plugin

Reinstalling also doesn't install

Feature request: allow locking position of the crafting log's side window

I usually have my crafting log window in the upper right of my screen, which means that this window is hidden off-screen. I'd like to keep my log there, but still have that window in a fixed position, which is currently only possible when it's attached to the right side of the crafting log.

Ideally, it would be nice to be able to attach to it to the right side as well, but the most useful thing for me would be a way to simply lock its position, so that I can put it somewhere and be sure it'll stay right there.

Allagan Tools ItemCount API changing

Just giving you a heads up, I generally don't like to change APIs as they should remain stable for the sake of anyone using them but in this case given this is the only repo I can see actively using it the potential damage surface is fairly low.

The AllaganTools.ItemCount IPC is changing to take a int for inventoryType, as I want to allow users to pass in -1 if they want to get an item count of all their inventories and the way I had it setup before was wrong.

New build should be going up fairly soon so you might need to adjust your code slightly

Any other API changes I'll either deprecate the API or make a new API.

How to hide Artisan search?

How to hide Artisan search?

Artisan unable to perform automatic repair.

This might be known already but just in case...

Since the update today, using 3.0.5.0, Artisan will stop to repair damaged gear at the threshold set but doesn't actually repair the gear. There is sufficient dark matter on hand, no df queue, etc. The repair menu remains open, and will re-open automatically, until you manually click repair. After repairing Artisan will resume crafting.

Here's what's captured in the log under verbose.

18:59:42.982 | VRB | [HM] Detected hook trampoline at 7FF6706FC9C0, stopping jump resolution.
18:59:42.982 | VRB | [HM] Registering hook at 0x7FF6706FC9C0 (minBytes=0x0, maxBytes=0x32)

Thanks for your time and help! I'm new to using Artisan, just within the past few weeks, but it's a blessing :)

Have to select an item from your inventory error

Loving the plugin so far! Ran into one small issue and not sure if it's a bug or i'm missing a setting somewhere. I created a list with sub items to do my GC stuff and while it was running through the list one of the components it made ended up not being HQ and was NQ. When it got to the recipe to create the item it just spammed Unable to craft. You have not selected all of the material I had to pause, select the one HQ item and one NQ item and then hit syn and resume to get it to continue.

Is there an option somewhere to allow using both types that i'm missing? I realize that my settings of Max Quality are what caused this little issue, I have it set to 90% and not 100% as I was doing one of the Ixal faction quests and it kept failing to craft one of the quest items trying to push for 100% HQ. Thoughts? Thanks!

Unable to use Withdraw From Retainer in List and from crafting Log after 6.58 patch

After attempting to use the Re-stock from retainers option in a crafting list, being next to a summoning bell will select and open the retainers interface but will not proceed from there. Selecting Withdraw from Retainer in the crafting menu does not seem to get any response next to a summoning bell and does not select it.

Standing up after every craft

Don't know if its a setting i have on but even when i am attempting to craft the same item multiple times it always makes my character stand back up after completing each craft.

Feature Request: Ability to filter Universalis prices by cross-world/world

Optimal World For Buying column usually suggests world out my current DC
In example here - Lich

[FEATURE REQUEST] Being able to add multiple quantity of a recipe to crafting list

Would be cool with maybe a modifyer (like ALT, SHIFT, CTRL) to right click > add to crafting list, that would open a popup where you can enter a number that would be the quantity to add to the crafting list (adjusting th subcraft quantity too)

Feature: Substitute Prudent Touch for Basic Touch when Waste Not is active?

Executing a 100% HQ Grade 4 skybuilders macro is a strong use-case for Artisan, but a trick that can be used in ffxiv macros isn't possible with Artisan macros:

/ac "Prudent Touch"
/ac "Basic Touch"  <wait.3>

This takes advantage of the macro falling through failed actions to create an if-else logic, where only one of the two actions ends up being executed for each pair. This is used because it is possible for Primed (buff lasts an additional 2 steps) to proc when Waste Not II is executed, which will block the ability to execute Prudent Touch later in the macro.

This isn't something that could be solved by having conditionals on buffs either, since using one of the actions consumes the buff.

Would you consider adding this logic, similar to or as part of the "upgrade quality" feature macros already have? I inserted the following code in to achieve the same effect for myself:

                    // Expert craft macros may encounter unexpectedly long Waste Not buffs due to Primed procs.
                    // If Waste Not is active, substitute Prudent Touch with Basic/Standard/Advanced touch instead.
                    if (CurrentRecipe.IsExpert && CurrentRecommendation == Skills.PrudentTouch)
                    {
                        bool wasteNotActive = CurrentCraftMethods.GetStatus(Buffs.WasteNot) != null || CurrentCraftMethods.GetStatus(Buffs.WasteNot2) != null;
                        if (wasteNotActive)
                            CurrentRecommendation = Skills.BasicTouch;
                    }

Here is the full macro used for reference:

Muscle Memory
Final Appraisal
Manipulation
Veneration
Waste Not II       <-- a Primed proc may occur here
Groundwork
Groundwork
Preparatory Touch
Innovation
Preparatory Touch
Basic Touch
Standard Touch
Advanced Touch
Innovation
Prudent Touch       <-- the macro will fail here if a Primed proc occurs on Waste Not II
Prudent Touch
Prudent Touch
Trained Finesse
Innovation
Great Strides
Trained Finesse
Great Strides
Byregot's Blessing
Basic Synthesis

Feature: remember amount of HQ/NQ material used, or disable auto HQ mat selection

For example, a recipe necessitates two ingredients, but my macro only requires one HQ ingredient to craft the recipe in HQ quality. However, the current endurance mode automatically utilizes the maximum amount of HQ material, which is 2.

Could you kindly add a checkbox to disable the auto HQ material quantity adjustment, or implement a mechanism to remember the amount of HQ/NQ material used, or introduce an option for "Minimum starting quality" in the macro settings? This would significantly save time when crafting the HQ ingredient.

Auto-deselects materials after Materia extraction in an endurance craft

I'm quite sure before during an endurance craft it would extract materia from spiritbond gear and continue (with the default max HQ item selection).
However, it now deselects your material selections and disables endurance because of "too many errors in succession."

EDIT: After trying it more, it's only when the craft needs to use a HQ item, it'll be deselected once it goes back to the crafting menu.

HQ mats aren't being selected

Hi all

The plugin errors out after repairing/extracting or drinking an item. It doesn't select any HQ items for the craft.

Any idea why this is?

Thanks

adjusting quantity in a list doesnt adjust subcraft

I was hoping that adjusting the quantity in a craft would adjust the subcraft but it does not.
Bug or expected ?
If expected, it would be a nice feature to have

Game freezes on craft completion

Not sure if it's just me, but if I have a large amount of things to craft my game will freeze for a few seconds after it uses the final progress ability. This sometimes cause my game to crash fully.

Bug?: Teamcraft Exporting list A while crafting list B will export list B instead

Steps to reproduce:

1. select a list, then start crafting it
   

2. select another list, then hit the Teamcraft Export button
   

3. paste the resulting text into your browser to discover, to your dismay, that you have exported the stuff you're currently crafting, not the next item on your bucket list:
   

I can reproduce this with any list I test it with, but I have no idea if it's not just something on my end. So I put the question mark after "bug". You know how idiosyncratic these setups are.

Turn-in for FC crafting

I think the title is very self-explanatory, but having a turn-in mode for the FC workshop would be a huge help as it is really damn tedious to do manually

Feature Request: Export remaining ingredients list as plain text

Hi,

could we have a button to export remaining/needed ingredients to fulfill the current crafting list ingredient list as plain text like

10x Iron Ore
20x Upland Wheat

it would also work for tools with parsers like in ARC allow to just click import to import the whole missing ingredient list instead of adding them one by one

I can't open Artisan anymore

I updated my plugins (probably also Artisan) while working on a crafting list.
It caused my game to crash.

Now I can't open Artisan anymore. Here's what I've tried:

• Restarting the game
• Turning off the addon (causes an unload error so I can't turn it on again)
• Uninstalling and re-installing the addon

If you need any more information, feel free to reach out.

Macro does not advance when executing upgraded actions

Because of the change made in 918006f -- specifically

Artisan/Artisan/RawInformation/ActionWatching.cs

Line 119 in 918006f

if (allOfSameName.Any(x => x == macro.MacroActions[MacroStep]))

where it checks if the executed action was programmed in to the macro, using the "Upgrade Quality Actions" to substitute macro actions causes the macro not to advance and it will execute extra actions instead.

Unable to use endurance mode for the WVR lv.88 recipe "AR-Caean Velvet"

I've found I'm unable to use endurance mode for this recipe specifically. No other recipes are affected. I first noticed this issue a few weeks back but have rediscovered it recently, so it's not fixed by restarts.

It doesn't seem to matter whether the recipe is found through the crafting log list by level, through favourites, or through search. The window to select a macro shows the previously selected recipe (eg: if I do some Scarlet Moko Cloth first, when I select the AR-Caean Velvet recipe the window incorrectly says "Use a macro for this recipe (Scarlet Moko Cloth)". If the previously selected recipe does not have the required materials to craft (eg: I have no Scarlet Moko Grass), attempting to enable endurance mode on AR-Caean Velvet or use the "Craft X Times" option, Artisan will enable and then disable endurance mode immediately as if it has run out of materials, making no crafts.

I've managed to find a workaround for it by finding a recipe I do have the materials for to select before swapping to AR-Caean Velvet (in this case the AR-Caean Velvet Cap of Fending right below it). The macro selection window is still showing the incorrect recipe (the Cap of Fending) but crafts the AR-Caean Velvet I selected second.

"Max Quality%" attribute does not have an effect when creating collectibles

Due to insufficient equipment grade or attributes, it may only be possible to reach the first or second stage when creating collectibles. I would like to modify or add a field to limit the quality progression bar.

Feature Request(s): Improve QoL for Ishgard Restoration Expert crafts

• Macro: Add one of the below options to skip a step if the corresponding condition is true (in order of grokability):
  • Not enough CP
  • Less than X CP remaining
  • Less than X CP remaining after use
• General Solver: Use Delicate Synthesis if possible to complete an expert craft unless already completely maxed out on quality, or at least make it an option to try maxing out quality even after reaching the last collectability breakpoint.

This is because Ishgard restoration crafts give bonus points for having more quality beyond reaching each breakpoint. So I wanted to have the option to either make a macro that adds another quality step in the end if I got unlucky with quality increases, but lucky with CP savings OR have the auto solver complete the craft for me, but the former just stops executing if I don't have enough CP and am not maxed out while the latter just goes "ok, last breakpoint is reached - time to complete the craft" without adding the last few points of quality.

Game Crashes

When interacting with the overlay, the game sometimes crashes.

Unhandled native exception occurred at ffxiv_dx11.exe+92F058
Code: C0000005

QOL Feature request: allow setting items to 0 or toggle in crafting list editor

Use case example:

I'm a crafter who wants to craft a full set of fending gear but I already have the rings. I have a crafting list set up for a full set of gear but want to skip the rings so I set the rings to x0 or I click "skip" or select a disable/enable item toggle. This way I don't have to remove the item and readd it later.

The way it is currently: I'll have to remove the item then readd it later, setting up the macro, food and such all over again. If I try to set an item to 0 it reverts to the previous amount.