pwcazenave / pyfvcom Goto Github PK

I'm using the python in version 3.7.
The usage of strftime(''%s) is invalid now, so it should be replaced with the method timestamp.

Hello,

When I provide the "extents" input to the Plotter function, it did NOT produce the axes labels.
You can find an example of command below;
Best Regards,
Murat

plot = Plotter(fvcom,
figsize=(20, 20),
res='f',
vmin=28,
extents=[26.35,27.2,38.25,38.8],
vmax=39.3,
tick_inc=(4, 2),
cb_label='{} ({})'.format(fvcom.atts.salinity.long_name,
fvcom.atts.salinity.units),
cmap=cm.haline)

Can not get file h_tpxo9.nc from the url in example.
But I can get another files names grid_tpxo9_atlas_30_v5.nc, h_q1_tpxo9_atlas_30_v5.nc and so on.
The file is separated and variables name has changed，how can i use then?

when I run the function 'add_tpxo_tides' , some trouble showed:
D:\software\Anaconda3\lib\site-packages\scipy\interpolate\interpolate.py:2530: RuntimeWarning: invalid value encountered in true_divide
(grid[i + 1] - grid[i]))
D:\software\Anaconda3\lib\site-packages\utide_reconstruct.py:106: RuntimeWarning: invalid value encountered in greater_equal
ind = np.logical_and(SNR >= min_SNR, PE >= min_PE)

so I can not wirter tides to nc file

Hi to whom it may concern,

cartopy is missing from the setup.py install_requires. See below:

Matplotlib is building the font cache; this may take a moment.

ModuleNotFoundError Traceback (most recent call last)
in ()
----> 1 from PyFVCOM.read import FileReader

...\lib\site-packages\PyFVCOM_init_.py in ()
23 from PyFVCOM import tidal_ellipse
24 from PyFVCOM import tide
---> 25 from PyFVCOM import plot
26 from PyFVCOM import preproc
27 from PyFVCOM import read

...\lib\site-packages\PyFVCOM\plot.py in ()
7 from pathlib import Path
8
----> 9 import cartopy.crs as ccrs
10 import cartopy.feature as cfeature
11 import matplotlib.widgets

ModuleNotFoundError: No module named 'cartopy'
​

Error in PyFVCOM.tide.lanczos, the error is specifically in the definition of _spectral_filtering (line 1396). I think it need to be replaced:

Cx = scipy.fft.fft(x.ravel())

instead of

Cx = scipy.fft(x.ravel())

The function julian_day in tide_tools.py, when calculate Julian Day , such as:
julian, modified = jdcal.gcal2jd(year, month, day)
julian += (hour + (minute / 60.0) + (second / 3600.0)) / 24.0
modified += (hour + (minute / 60.0) + (second / 3600.0)) / 24.0
the first output of jdcal.gcal2jd: julian is equal to MJD_0=2451545.5,the second output of jdcal.gcal2jd: modified is MJD, and if want to return Julian Day ,we must add the julian and modified together.
So when the function calculate Julian Day just use the julian is wrong. I think it would like this:
julian, modified = jdcal.gcal2jd(year, month, day)
modified += (hour + (minute / 60.0) + (second / 3600.0)) / 24.0
julian+=modified

Hi 👊

This is my first visit to this fine repo, but it seems you have been working hard to keep all dependencies updated so far.

Once you have closed this issue, I'll create seperate pull requests for every update as soon as I find one.

That's it for now!

Happy merging! 🤖

Hi,
There is no "sample.nc" file in the examples folder.
It would be nice to have it or a link in the README to download it, to test the example scripts.
Thank you.