Comments (6)
It's needed if we want to observe WiFi access points. For just observing connectivity it's actually not needed. We can think of managing this permission in a better way or extracting WiFi monitoring functionality to a separate library.
from reactivenetwork.
For now, you can use such solution to override this permission in your app: http://stackoverflow.com/questions/27962789/android-gradle-manifest-merger-override-uses-permission-attribute-coming-from
from reactivenetwork.
I see... Indeed I only use the library for checking the connectivity status. Interestingly enough, the latest Android Studio lint didn't spot the problem when removing said permission (whilst complaining when removing any of the other ones).
I wonder if it would be possible to only have said permission if building for anything earlier than API23 and switch to a request-permission model otherwise, but probably it'd be adding a bit too much complexity on something self-contained such as ReactiveNetwork and that it's doing its job flawlessly otherwise :)
Anyway, I'll take a look at the SO link you mention, and thanks a lot for clarifying the issue so quickly.
Feel free to close this issue if you see fit, then :)
from reactivenetwork.
I know about permission model in Android 6, but I also want to keep compatibility with Android 4 and up for now, because some people still use it. Moreover, I think that handling permission requests shouldn't be part of the library.
Thanks for your question. Feel free to ask more, if you have any doubts. :)
from reactivenetwork.
After merging PR #67 to the master branch, this permission can be removed from the Manifest of the library. In release v. 0.4.0, this permission will be no longer needed.
from reactivenetwork.
Permission removed by PR #67.
from reactivenetwork.
Related Issues (20)
- "NetworkCallback was already unregistered" if re-using Observable HOT 4
- Migrate CI from Travis to GitHub Actions
- connection speed HOT 5
- fix error prone config for the RxJava2.x branch after bumping its version HOT 1
- Release 4.0.0-rx3 HOT 11
- [Question] What is a reason to use http instead of https protocol in your library internal requests? HOT 1
- How know which connection type is better ? HOT 1
- NetworkInfo.State Deprecated HOT 1
- Rx Java 3 support
- BroadCast Receiver stopped working HOT 5
- Google pixel wifi change event is received in 30 sec delay HOT 5
- java.lang.IllegalArgumentException: Too many NetworkRequests filed in Android Nougat(7.1.1). HOT 7
- MarshmallowNetworkObservingStrategy.java line 80 HOT 4
- isConnectedToInternet always false
- Internet connectivity issue: Could not establish connection with WalledGardenStrategy HOT 1
- ReactiveNetwork(RN) usage of IPv6 and DNS results prioritization HOT 1
- Will there be a version for Kotlin Flow ? HOT 2
- Fix Robolectric tests HOT 1
- How to check Internet Connection in Background continuously even if App is Running or Not/Closed.. HOT 1
- Th
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactivenetwork.