GithubHelp home page GithubHelp logo

Comments (7)

mhkabir avatar mhkabir commented on July 28, 2024

We will update it. LPE is still the recommended estimator for motion capture and vision use-cases till we have more testing on EKF2. e.g PX4/PX4-Autopilot#7408

from px4-devguide.

bramsvs avatar bramsvs commented on July 28, 2024

@mhkabir Maybe time to update this? I'm happy to help but I have to get it working first ;)

from px4-devguide.

hamishwillee avatar hamishwillee commented on July 28, 2024

... and probably LPE no longer the recommended estimator @mhkabir

from px4-devguide.

mhkabir avatar mhkabir commented on July 28, 2024

Yeah, we have EKF2 dialed in now and should be the recommend estimator.

from px4-devguide.

hamishwillee avatar hamishwillee commented on July 28, 2024

Thanks @mhkabir . Can you help @bramsvs get started?

from px4-devguide.

m0oz avatar m0oz commented on July 28, 2024

Hey there. Just chiming in.

It seems like this is still relevant. I haven't contributed to the doc yet but I am about to start my implementation of external pose estimate + EKF2 and I could add my findings to
https://dev.px4.io/en/ros/external_position_estimation.html

Regarding the overall structure of the doc on external vision:
To me it was counter-intuitive to find the doc on external vision split between
Robotics/ROS/ExternalPositionEstimate and Tutorials/eclEKF
I think https://dev.px4.io/en/tutorials would need an additional page that gives more details on how to setup your vio->mavros->px4 pipeline and how to tune ekf2 for this application.
Robotics/ROS/ExternalPositionEstimate could then just link to this tutorial as it currently reads as a tutorial anyways.

I think this supports what was mentioned here #530 @hamishwillee

from px4-devguide.

hamishwillee avatar hamishwillee commented on July 28, 2024

Hi @m0oz

We definitely need clear docs on external vision. It is completely appropriate for a separate EKF tutorial, but the important aspects should either be included or strongly linked from the external position docs.
I am not sure having a separate document for vio->mavros->px4 makes sense - it probably can be merged - or the common bits should be split.

I should also add that I am trying to kill that whole section on tutorials by moving the docs into sections with associated content and making them more guide than tutorial. I don't hate tutorials, but there is a tendency for them to cover just one setup case and not have enough information for people to extend them to more general use cases.

With respect to the ExternalPositionDoc, is any of what you're proposing covered in the updated in #573 ?

Cheers
H

PS I appreciate my response is a bit superficial. Once you've looked at #573 I will think about this more "completely". Your help/experience on getting the information for this updated will be invaluable.

from px4-devguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.