Comments (20)
I can't get you log to work on the replay. Will investigate further.
from px4-ecl.
@pickledgator It's because PX4/PX4-Autopilot#4382 was not finished. If you want help with the EV feature, then you must get that PR cleaned up, tested and pulled into master. @LorenzMeier for info.
from px4-ecl.
Thanks, @priseborough. Will get an updated log out when #4382 is resolved.
from px4-ecl.
@pickledgator Can you please get a replay log using the following branch and send it too me as @devbharat is currently unable to generate logs. This will help me get #4382 resolved.
https://github.com/priseborough/Firmware/tree/px4_push_ev_Ekf2_replay
TXS
from px4-ecl.
@priseborough I pulled in your branch compiled and flash, but apparently my logs are still corrupt. They open in FlightPlot, but are missing tons of fields like, LPOS but have fields like attitude. When the px4log is loaded, it says there are errors but I have no idea how to troubleshoot this. My process was to pull down PX4/master, then merge in your branch and add the few lines of modifications that I need to get my vision data piped in. All data shows up fine live in QGC, but somehow isn't being logged correctly. Any help is appreciated so that I can get you some data.
from px4-ecl.
Are you talking about the replay log ? It does not log LPOS etc, only replay stuff (test RPL1.t) and attitude. So that is OK. To see if vision data is logged in replay, test RPL5.x for external vision position x etc.
What is the error you get when you try to replay the logfile like this:
make posix_sitl_replay replay logfile=~/Downloads/Whatever/log001.px4log
from px4-ecl.
@pickledgator I think I know what the problem could be - the changes to the field descriptor for the RPL5 message did not make it into the PR. I will fix that now.
OK - the fix has been pushed. As @devbharat points out, when replay logging is enabled, most of the other log messages are missing to save bandwidth and ensure no dropped messages. You will also need to SET_SDLOG_PRIO_BOOST to 3 and use a good quality flash card.
TXS
from px4-ecl.
Pulled in the change and collected a log. No errors when running the posix_sitl_replay. Changed PRIO_BOOST to 3 for this dataset. AID_MASK set to 24 -- QGC shows lpos converging to vision, still feels like the logs are missing data (eg, no RPL5.x). Using SD card that came with pixhawk, so assuming that is sufficient.
https://www.dropbox.com/s/bqdkoi62x3j4ddi/log001.px4log?dl=1
https://www.dropbox.com/s/cymfzflsjcivofc/replay.px4log?dl=1
https://www.dropbox.com/s/88lrtko8eqfwi72/replay_replayed.px4log?dl=1
from px4-ecl.
OK, so no RPL5 messages were extracted and there are lots of warnings about bad bytes in the log . I found a bug in the replay program which has been fixed so have pushed this and another minor correction, but neither explain the bug. @Tumbili are you able to do a review of the RPL5 message logging to see if you can find anything?
from px4-ecl.
I'll dig in a bit more in the morning with some console prints to see if I can track down the lack of RPL5 data.
from px4-ecl.
Ah! Found it. Check the enum numbering here: sdlog2_messages.h#L561-L623. There are multiple of the same number. Also watch out for sdlog2_messages.h#L435-L439, there's an out of order 53 in there.
I'll let you fix it in your PR so we don't have to do two merges. Fixing the enums results in px4logs with no errors, and the RPL data is there.
replay enabled log file here using ev and laser (note that I had to increase the ecl buffer size for both EV and RANGE to 50 to handle 100Hz updates): http://logs.uaventure.com/view/hFiVoT4E8HVMgaAxtpnMuM
from px4-ecl.
pushed the fixes
from px4-ecl.
Can you please record some more data using the updated branch. The enum numbering used for the logging and replay have to be consistent.
from px4-ecl.
This should have the correct enums from your PR.
http://logs.uaventure.com/view/w9UrF6JWWbQageMVdp4mZ3
And a longer log with some additional motions
http://logs.uaventure.com/view/dhwAuxZz5gQyqrHKZ6Tku3
100Hz laser and EV updates. Also have a small change around control.cpp#L452-L470 that disables EV height and fuses only laser measurements per comments from #151.
from px4-ecl.
The replay results using your data with PX4/PX4-Autopilot#4647 were excellent. I will enable adjustment of the position noise via parameter given it is not yet supported over mavlink and then I think it should be good to pull in.
from px4-ecl.
Awesome, looking forward to pulling in the updates and running a test flight.
from px4-ecl.
Hoping to run a full flight test of the new EV changes sometime this afternoon. Will provide log after collected.
from px4-ecl.
@pickledgator what is the status on your testing? If it was successful, then we can close this - if not can you please provide replay logs. TXS.
from px4-ecl.
Had a crash on inav (with corrupted log unfortunately since we had to pull power), so in process of hardware rebuild. Hope to be able to run another ECL/ekf2 flight log by the end of next week.
from px4-ecl.
Unable to reproduce. Closed due to lack of follow-up information from the OP.
from px4-ecl.
Related Issues (20)
- flow fusion of ekf2 HOT 4
- I have 4 quadcopter there altitude is not same for all 4 currently using barometer as primary source can anyone tell me how to fuse baro and rangefinder in px4 HOT 3
- Constant drift when EV frequency drops below a certain threshold HOT 3
- EKF2 model not quite suitable for rover? HOT 3
- ranger fusion about ekf HOT 1
- Better height estimation using range sensor help me ? HOT 1
- EKF mathematical equations HOT 3
- EKF estimates diverge from the Rangefinder and EV inputs in Z-axis HOT 9
- What's the principle of fusing the gps yaw? HOT 1
- can anyone please help me for better height estimation with baro and rangefinder for multiple vehicle as of now they are not at same height in offboard HOT 2
- ekf terrain process HOT 5
- EKFGSF ahrsAlignYaw() does not affect filter state HOT 2
- <deleted>
- Ekfgsf_yaw in rtk gps HOT 2
- External vision yaw being rejected for portions of the flight HOT 2
- vector2f type assigned with slice type
- Convert posecovariance from Nav_msgs::odom to px4 VehicleVisualOdometry.msg pose_covariance
- Reporting a vulnerability
- EKF not tracking external vision position sent through MAVROS HOT 2
- sympy generated code vs final code HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from px4-ecl.