Comments (14)
from pypdf.
Release 4.3.1 failed in CI again.
As far as I understand, the executing user (probably GitHub Actions in this case) needs push permissions for protected branches - even if just creating a tag: https://github.blog/changelog/2021-11-19-allow-bypassing-required-pull-requests/
from pypdf.
That worked. Thanks.
from pypdf.
I wonder if it's a limitation of using secrets.GITHUB_TOKEN
for trying to create a protected tag, where the user associated doesn't have admin/maintainer rights on the repo? Might need to use a PAT, though that feels like it would bypass the entire reason to have protected tags.
from pypdf.
As far as I remember, we already had discussions about PATs, but tried to avoid it as they have a limited lifetime as well. According to the docs, our approach should work, although it seems like push protections prevent this from actually running correctly.
from pypdf.
Yes, my guess was as well that this is a security mechanism. I'm uncertain if there is a reasonable way around it.
In the end, I also would trust you @stefan6419846 / @pubpub-zz enough to handle releases for pypdf. So I'm also thinking about simply giving you maintainer permissions.
from pypdf.
It looks to me like there's a tag there (at least now), but it's not signed, which is a departure from previous releases.
from pypdf.
Yes, the tag has been created in the meantime, but it should have been created automatically - this is what this issue seeks to further analyze. In this case, it seems like there is some setting which show an issue on the GitHub UI:
Do you rely on all tags being signed?
from pypdf.
from pypdf.
I could force-push a signed tag. Could that cause issues?
The workflow will attempt to create a new release on pypi, but that will fail (which is ok)
from pypdf.
In Debian our tooling is set up to pull from a signed tag, so for us, that's what's most important.
from pypdf.
@pubpub-zz @stefan6419846 You have done a great job as core contributors to pypdf for an extended period of time. I trust your intentions and abilities, hence I gave both of you the "Maintainer" permissions on the pypdf repository. That should mean you can trigger the release by merging a "REL: XYZ" commit in future.
from pypdf.
@kitterma pypdf releases relatively often. Is it fine when we just release the next release with a signed git tag? We could release 4.3.1 today :-)
edit: PR is prepared #2764
from pypdf.
I've created the tag manually via git tag -s 4.3.1
, pasting the part of the changelog, git push --tags
.
I'll look more into that next week 👀 🥲
from pypdf.
Related Issues (20)
- Broken docs link on PyPI HOT 3
- Filled Choice Fields Not Rendered Correctly By Adobe Acrobat HOT 6
- `TypeError` in `_cmap.py` when calling `extract_text()` HOT 7
- Documentation: Adding internal link code snippet is incorrect. HOT 2
- [4.3.0] Regression when decoding strings
- PdfWriter unable to add reader HOT 8
- Paragraph field not showing correct HOT 4
- Using PdfReader causes a crash HOT 9
- Add viewport (bbox) of image rendered in the page to the FileImage class HOT 6
- `merge_page` increases file size of resulting pdf superlinearly HOT 10
- Ability to set font when updating form fields
- PdfWriter created from file stream does not work in 4.3.x (worked in 4.2.0) HOT 14
- New lines no longer included in extract_text() on 4.3 for a specific PDF file HOT 1
- PDF-Form not editable after filling out text field (after upgrade from 3.9.* to 4.3*) HOT 3
- Unhandled ZeroDivisionError in _extended_image_frombytes HOT 1
- transfer_rotation_to_content and annotations HOT 1
- Freeze/huge memory use for one page of PDF file HOT 12
- ENH: compress PDF merging identical objects
- Type hint for page.images needs adjusting HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pypdf.