How to handle multiple widgets with same "implicit" ID about pyimgui

[swistakm]

It is definitely a good idea to have the extra functions and utilities that do not exist in C++ API in separate module. It will improve code organization and help in documenting it properly. We already have few of such functions e.g. font, styled, istyled, vertex_buffer_*.

Still I would not care much about developer confusion at this moment. I think that benefits of having them importable from one place instead of multiple submodules outweights the cons. This is also in spirit of the one-header libraries like ImGui itself.

My idea is to have at least two Cython modules:

• core.pyx - for everything that exists directly in core C++ API
• extras.pyx - for anything extra (python-specific helpers, context managers) that is not part of C++ API

But combine them in __init__.py in following way:

from imgui.core import *  # noqa
from imgui import core
from imgui.extras import *  # noqa
from imgui import extras

That way we will help to maintain backwards compatibility, make possible for some developers to be very specific about core/extras usage, and also make possible for other developers to have very simpe one-import code.

[overdev]

Off-topic: Good to have you back. I was beginning to think you gave up on pyimgui.

This happens only in pyimgui? I mean, it does not occur in C++'s imgui?

[swistakm]

Oh, I didn't gave up on this project :). I simply had a very intense period at work so had to put few open source projects on hiatus. But I'm trying to get back to them.

Regarding the issue. I'm pretty sure this happens in barre C++ ImGui too because the this is the way how most immediate-mode GUIs are implemented i.e. every widget get's it's unique and (usually) explicit identifier. In this case the labels are used as identifiers. Usually this is acceptable simplification because it isn't common to have multiple same-labelled widgets in the same context (window, modal etc.)

[pconerly]

I like the idea of imgui.scope, but I wonder if we should put it into a different namespace? Having the python imgui module be a combination of imgui-cpp methods and pyimgui helpers might be confusing for coders?

Maybe imgui.helpers.scope ? or imgui.py_scope? I don't know; naming is hard.

[602p]

I've submitted a PR for a patch to expose PushID and PopID and a context wrapper as discussed.

It's also possible to append some unique text to a name after ## to make ids not collide. E.g. imgui.button('foo##1') and imgui.button('foo##2') don't collide, but are both displayed as foo.

[swistakm]

Closing this as we already have imgui.extra submodule and I have added new scoped context manager.

[swistakm]

Feature available in 1.2.0.