Comments (3)
This is miscalled in pymoca/pymoca test/notebooks/Spring,ipynb:
"control.rlocus(ss[0,0], klist=pl.logspace(-2,1,1000));\n",
from python-control.
The first line of the docstring for rlocus suggests that there's a kwarg klist,
Only for the MATLAB wrapper though. The MATLAB docs call the parameter k
by the way.
Using a MATLAB wrapper with a python kwarg is somehow unusual.
PR welcome.
This is miscalled in pymoca/pymoca test/notebooks/Spring,ipynb:
The MATLAB wrapper is not part of that call. The kwarg for control.rlocus has been kvect
for 13 years: 8ebb73b.
from python-control.
Ah, yes, sorry I see now that control.rlocus
doesn't call control.matlab.wrappers.rlocus
at all but rather control.root_locus_plot
; I had overlooked this:
python-control/control/rlocus.py
Line 452 in e4a03e8
My real problem was pymoca/pymoca#324 so I'll look over there at fixing that. I'm not presently concerned with control.matlab
, but I'll turn in the PR as requested, while I'm at it.
from python-control.
Related Issues (20)
- How to convert finite step response model to state space representation? HOT 2
- Output calcs produce 0's at every other call HOT 2
- equations not showing up correctly in online docs HOT 2
- IndexError: index -1 is out of bounds for axis 0 with size 0 HOT 3
- "Interconnect" input specification. HOT 2
- UnboundLocalError: local variable 's' referenced before assignment HOT 2
- plotting example mimo system HOT 1
- Display Connection Matrix HOT 8
- (accidentally opened issue with garbage title) HOT 1
- Observability Gramian for discrete-time systems HOT 8
- `phase_plot` ODE function signature is not compatible with `solve_ivp` and `StateSpace.dynamics` HOT 2
- Strange nondeterministic issues when using `phase_plot` with `X`, `Y` and `X0` set HOT 1
- `control.mixsyn` hangs on M1 HOT 2
- Scaling for control.impulse_response discrete time is not correct HOT 6
- documentation out of date HOT 1
- Wrong parameter name in documentation HOT 1
- Parallel system interconnection using `control.interconnect()` HOT 4
- Plotting nyquist plot from FrequencyResponseData fails HOT 3
- forced_response giving different output depending on Python and/or numpy version HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-control.