GithubHelp home page GithubHelp logo

Comments (3)

gdmcbain avatar gdmcbain commented on July 2, 2024

This is miscalled in pymoca/pymoca test/notebooks/Spring,ipynb:

    "control.rlocus(ss[0,0], klist=pl.logspace(-2,1,1000));\n",

from python-control.

bnavigator avatar bnavigator commented on July 2, 2024

The first line of the docstring for rlocus suggests that there's a kwarg klist,

Only for the MATLAB wrapper though. The MATLAB docs call the parameter k by the way.
Using a MATLAB wrapper with a python kwarg is somehow unusual.

PR welcome.

This is miscalled in pymoca/pymoca test/notebooks/Spring,ipynb:

The MATLAB wrapper is not part of that call. The kwarg for control.rlocus has been kvect for 13 years: 8ebb73b.

from python-control.

gdmcbain avatar gdmcbain commented on July 2, 2024

Ah, yes, sorry I see now that control.rlocus doesn't call control.matlab.wrappers.rlocus at all but rather control.root_locus_plot; I had overlooked this:

rlocus = root_locus_plot

My real problem was pymoca/pymoca#324 so I'll look over there at fixing that. I'm not presently concerned with control.matlab, but I'll turn in the PR as requested, while I'm at it.

from python-control.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.