python-markdown / github-links Goto Github PK

This could be useful for GitHub Enterprise setups (or even Gitlab).

The current workaround is:

import mdx_gh_links

mdx_gh_links.URL_BASE = 'https://ghe.bigcorp.com'
        
m = markdown.markdown(
  some_input,
  extensions=[mdx_gh_links.GithubLinks()],
)

If text is already in a link, it should be ignored. For example. if a document were to contain...

[@waylan](https://example.com/waylan)

The link would be parsed (as it should), and then this extension would parse the link label (@waylan) and nest a second link inside the first one, resulting in the following:

<a href="https://example.com/waylan">
    <a class="gh-link gh-mention" 'href="https://github.com/waylan" title="GitHub User: @waylan">@waylan</a>
</a>

In addition to the wierdness of the nested links, notice that the first link is not a GitHub mention, but something else. Of course as a workaround, you can escape the mention, like this:

[\@waylan](https://example.com/waylan)

But it should be smart enough to not insert a link inside another link. The problem is that Python-Markdown doesn't really provide a way to check that (inline patterns have no access to their parent). And it gets potentially more complicated when there is multiple levels of nesting. Consider this:

[**@waylan**](https://example.com/waylan)

The direct parent is not a link (<a> tag), but an ancestor is. Therefore, the behavior should be the same as if the direct parent was a link.

Cause: Python-Markdown/markdown@a767b2d

Error: ImportError: cannot import name 'etree' from 'markdown.util'

I see that there's an old commit fixing this but it's not included in any release.
7b3a23c

This is a follow-up on the discussion in #14.

Latest release is failing to pick up issues and author references in the form of #123 or @seanbudd

set up:

Markdown==3.5.1
mdx_truly_sane_lists==1.3
markdown-link-attr-modifier==0.2.1
mdx-gh-links==0.4

Note 0.3.1 works fine