qaharmdz / opencart-shortcodes Goto Github PK

Surprisingly, I can't output the html-content module using a short code.
Maybe you should add this functionality, because it can be useful in some situations.

Sorry if this may not the correct thread, but i cannot see another one for a discussion like this.
Basically I welcome that your scripts are following better coding practices and do not use a closing tag.

But what I am missing (and I used to do that since many years as developer) are tags like the phpDocumentor use.
This starts at the beginning of each script where I can see quick from when this script is (last commit) - if correct tags are used.

Maybe these tags could be used in future?

How about add 'group' option to login method ? so we can target specific group

PHP8 introduced a breaking change with the way is_callable works (https://www.php.net/manual/en/migration80.incompatible.php). The change prevents non-static methods from being queried as a static method and shortcodes utilises a static query.

As such

if (is_callable(get_class($class).'::'.$func)) {

Needs to be updated to:=

if (is_callable([$class, $func]) {

i need to get a self title from product and display it in product description
how to get self product id?
[link_product id="self" /]

In http://qahar.github.io/opencart-shortcodes/install.html

Require vQmod is v2.3.2 or above

it should be 2.4.0 , because you using static call VQMod::modCheck

Example image shortcode
[image src="catalog/demo/compaq_presario.jpg" img_w="300" img_h="184" alt="compaq-presario-2014" align="center" /]

If PHP 7.1 is installed on the server, an error occurs.
Warning: A non-numeric value encountered in system/helper/shortcodes_default.php on line 364