qalle-git / esx-qalle-sellvehicles

This gives you the opportunity to sell cars to eachother.

Hi, I'm qalle

• 🏫 I am a Computer Science and Software Engineer student at Chalmers Institute of Technology in Gothenburg.
• FiveM Enthusiast, with hundreds of resources made, both public and private.
• 🧑‍💻 I love using Software as a solution for every Problem.
• 💻 I am a fluent programmer in Lua, C#, TypeScript and Python.
• 🧑‍🎓 I’m currently learning Computer Science and how to use Assembly Language.
• 🤓 Always learning new things.

Statistics

esx-qalle-sellvehicles's Issues

When buy car cannot spawn car in garage

So the title say it. But when i sell a car then can the player who buy them not spawn him in garage??

2 Garages both working, I have only 1 error

If i buy a car on the first 1 everything works perfect..on the second im getting error..
I change the SQL Tables
1st Garage SQL Table: vehicles_for_sale
2nd Garage SQL Table: vehicles_for_sale2

and i change those
1st Garage:
ESX.RegisterServerCallback("esx-qalle-sellvehicles:buyVehicle", function(source, cb, vehProps, price)
2nd Garage
ESX.RegisterServerCallback("esx-qalle-sellvehicles:buyVehicle2", function(source, cb, vehProps, price)

stack traceback:
        @esx_qalle-sellvehicles/server/main.lua:85: in upvalue 'ref'
        citizen:/scripting/lua/scheduler.lua:389: in function <citizen:/scripting/lua/scheduler.lua:388>
        [C]: in function 'xpcall'
        citizen:/scripting/lua/scheduler.lua:388: in function <citizen:/scripting/lua/scheduler.lua:387>
stack traceback:
        [C]: in function 'error'
        citizen:/scripting/lua/scheduler.lua:403: in function <citizen:/scripting/lua/scheduler.lua:372>
Error running system event handling function for resource es_extended: citizen:/scripting/lua/scheduler.lua:41: Failed to execute thread: citizen:/scripting/lua/MessagePack.lua:830: missing bytes
stack traceback:
        [C]: in function 'error'
        citizen:/scripting/lua/MessagePack.lua:830: in method 'underflow'
        citizen:/scripting/lua/MessagePack.lua:465: in field 'any'
        citizen:/scripting/lua/MessagePack.lua:860: in field 'unpack'
        citizen:/scripting/lua/scheduler.lua:626: in field '?'
        @es_extended/server/functions.lua:33: in field 'TriggerServerCallback'
        @es_extended/server/common.lua:63: in upvalue 'handler'
        citizen:/scripting/lua/scheduler.lua:219: in function <citizen:/scripting/lua/scheduler.lua:218>
stack traceback:
        [C]: in function 'error'
        citizen:/scripting/lua/scheduler.lua:41: in field 'CreateThreadNow'
        citizen:/scripting/lua/scheduler.lua:218: in function <citizen:/scripting/lua/scheduler.lua:182>

on this line

	if xPlayer.getAccount("bank")["money"] >= price or price == 0 then

If someone can help <3

players get no money when selling a car

players get no money when selling a car, no notifications or anything. i really want this script for my server but its kinda a necessity to give the players money when the car gets sold.

Vehicles dissapear

The vehicles dissapear when there is a server restart but instead they come bank they dont!!!!

They stay active in the database but are not showned. We have enough sell places in the config theres no error.

Does somebody know how to fix this please!

Cannot sell or retrieve vehicles

I got an error after switching to the new es_extended. I go to the place and sit in the car but when I click to buy it nothing happens

When the user is offline

When the user who owns the vehicle is disconnected, the money does not go to his account
[ERROR] [MySQL] [esx-qalle-sellvehicles] An error happens on MySQL for query "UPDATE users SET bank = bank + 50 WHERE identifier = '380529ae28a898a88a896ce1a64dd33362e5945c'": ER_BAD_FIELD_ERROR: Unknown column 'bank' in 'field list'

Got error Something went wrong, there was no car.

Hello recently players cannot get money when they are offline form my debug i figured its propably the script cannot somehow get identifier of user in users table or so and im scrwed now

Sell other people's cars

Hello! I'm trying to edit esx-qalle-sellvehicles (awesome script btw) so that players can sell other player's cars.

I looked into the server.lua and the "owner check" is right there :

function RetrievePlayerVehicles(newIdentifier, cb)
    local identifier = newIdentifier

    local yourVehicles = {}

    MySQL.Async.fetchAll("SELECT * FROM owned_vehicles WHERE owner = @identifier", {['@identifier'] = identifier}, function(result) 

        for id, values in pairs(result) do

            local vehicle = json.decode(values.vehicle)
            local plate = values.plate

            table.insert(yourVehicles, { vehicle = vehicle, plate = plate })
        end

        cb(yourVehicles)

    end)
end

So this function give the list of owned vehicles for the seller, and if the vehicle that's being sold is in that list, it works
I want the function to search by plate rather than listing user's plates to check if he owns the car

I suppose it's the way i need to edit the script but im not 100% sure
Any help pls? :)

Can't sell more then 11 cars

Can't sell more then 11 cars. Is this a glitch or bug or there is limit on client or server

Vehicule directly on garage.

Hello i need for my server to have vehicule directly on garage. I have update the sql request to add state.

MySQL.Async.execute("INSERT INTO owned_vehicles (plate, owner, vehicle, state) VALUES (@plate, @Identifier, @vehProps, @State)",
{
["@plate"] = plate,
["@Identifier"] = xPlayer["identifier"],
["@vehProps"] = json.encode(vehProps),
["@State"] = 1
}
)

Bank issue

[ script:oxmysql] SCRIPT ERROR in promise (unhandled): Error: esx-qalle-sellvehicles was unable to execute a query!
[ script:oxmysql] Unknown column 'bank' in 'field list'
[ script:oxmysql] SELECT bank FROM users WHERE identifier = 'char7:xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'
[ script:oxmysql] > query_default (@oxmysql/dist/server/build.js:16103)
[ script:oxmysql] > processTicksAndRejections (node:internal/process/task_queues:96)

It seems the sql file is uncomplete. I suggest to target the IBAN ID of the client, wich is already managed by financial scripts.

can't set price

when i come on the point to sell , i can't set the price , the menu stuck on set price

He can not sell a car

He can not sell a car. Has the apartment in line 40 server/main.lua v.plate? If I switch to a plate, the car can be sold but I can not own it

2 garages

How to make this work with 2 garages... because i got 2 garages with same cars on both

Offline Player does not receive money (FIX) ESX 1.9 VERSION

IF U R USING ESX 1.9 VERSION U CAN CHANGE YOUR server\main.lua like this
MySQL.Async.fetchAll('SELECT accounts FROM users WHERE identifier = @identifier', { ["@identifier"] = identifier }, function(result) if result[1] ~= nil then local accs = json.decode(result[1].accounts) accs.bank = accs.bank + cash print(accs.bank) MySQL.Async.execute("UPDATE users SET accounts = @newBank WHERE identifier = @identifier", { ["@identifier"] = identifier, ["@newBank"] = json.encode(accs) } ) end end)

Car can sometime spawn with door lock

prohibit players from purchasing !

Can be limited to car dealers to buy,players can sold.prohibit players from purchasing.Can it be done?Finished, thank you very much.

When buy car he dont come in the garage but in the impound

Hello so as the title say how can i fix this?

Brought used cars aren't owned by the play who brought them

It seems when people buy a used car, they own them but when they try to store them again they can't due to not owning them even though they do.

I'm unsure if this is something to do with your script or vehicle shop script. Either way any help would be awesome!

Person Pays full price, Seller only receives $1

Hey,
Having a issue with the plugin, Had a few people's car for sale in the lot, All for different prices. Some guy came and bought them, paid full price for them but sellers only received $1 for the sale.

Could you look into this as i love having this plugin on my server and would hate to remove it

Thanks

Vehicles in ground

I have this issue.. If I restart script or add new vehicle everything is fine.

CRITICAL - memory overload

Hey, there is problem with memory overload causing people to loosing textures of city, etc..

Offline Player does not receive money (FIX)

function UpdateCash(identifier, cash)
local xPlayer = ESX.GetPlayerFromIdentifier(identifier)

if xPlayer ~= nil then
	xPlayer.addAccountMoney("bank", cash)

	TriggerClientEvent("esx:showNotification", xPlayer.source, "Someone bought your vehicle and transferred $" .. cash)
else
	MySQL.Async.fetchAll('SELECT accounts FROM users WHERE identifier = @identifier', { ["@identifier"] = identifier }, function(result)
		if result[1] ~= nil then
    local accs = json.decode(result[1].accounts)

accs.bank = accs.bank + cash
MySQL.Async.execute("UPDATE users SET account = @NewBank WHERE identifier = @Identifier",
{
["@Identifier"] = identifier,
["@NewBank"] = json.encode(accs)
}
)
end
end)
end
end

Cars dissapear on server restart, but still in database

It seems to work fine but any cars left on sale are not put back from the database onto the for forecourt.

vehicle job

Hi
i have a problem with my script job when any one try to get a job car and open the trunk it said not your car
can u help me please
esx server

error:
[esx_jobs] An error happens for query "INSERT INTO owned_vehicles (plate, owner) VALUES (?, @owner) : ["WRK 4347"]": ER_BAD_NULL_ERROR: Column 'owner' cannot be null
[script:hop_vehcontro] event baseevents:enteringVehicle was not safe for net

offline player

to specify a job to resell the vehicle only the job (cardealer)

Hi can you help me to specify a job to resell the vehicle only the job (cardealer)?
So that the cardealer can sell is buy used vehicles

Seller doesnt get money!!

No errors client side or server side, latest version.

HELP ME PLease

I have a problem when i enter the price of the vehicles the dialog doesn't close

Running into this error when script starts

You can buy your own car

You actually can buy your own car when you put it for sale. I try it and it works.

People can cheat the price with cheat engine

So the title says people can set the price to 1

cant sell car

Hi im using an older version of Vehicleshop because the new one are buged as F.
so when i try to put it out for sale it say that i dont own the car. i understand that it has to do with tables in sql but mby you can help.