qarkai / welcomebot Goto Github PK

Currently, if WelcomeBot is kicked out (by a Freenode mistake, for example) or disconnected in a netsplit, the python process keeps running and unfortunately starts taking 100% CPU.

I looked at other bots and it seems the sane thing to do is exit without trying to reconnect. Re-running the program should be handled separately with a daemon or a shell script.

Reference: https://github.com/ayust/kitnirc/issues/15#issuecomment-50968217 (formatted as code as I don't want to ping the issue..)

With the recent spamwave on freenode, I wanted Welcomebot to understand that kicked persons do not need to be welcomed :) Here is a solution that works for me:

    if ircmsg.find("KICK " + bot.channel) != -1:
        for person in bot.newcomers:
            if ircmsg.find("KICK " + bot.channel + " " + person.clean_nick) != -1:
                bot.newcomers.remove(person)
                break

If you have an idea to make it more concise, feel free to change!
As you can imagine, the raw message contains the string

KICK #channel kickeduser

...while the actor is the one who did the kicking.

Edit: now I realised the solution only worked, if I did the kicking, but it failed if IZBot did the kicking. I don't understand why the message seemed to be ignored as bot.known_bots is only handled in case of PRIVMSG and JOIN.

It seems your changes to the block https://github.com/qarkai/WelcomeBot/blob/Py3/bot.py#L235 broke the "silence feature" of the bot.

Steps:

1. Join with a nickname not in nicks list
2. Change nick to something that is in nicks list before being greeted by the bot

Bot will greet with a numeric ID.

Expected behaviour would be to skip the greeting in this case.

After registering my bot and trying out identification, I noticed two things.

1. The PRIVMSG syntax was missing a : immediately before IDENTIFY (spaces in parameter are disallowed otherwise)
2. I had to add a 10 second sleep after the NickServ identification message so it had time to be picked up (otherwise I was unable to join a channel that required users to be identified)

Here are my changes

            ircconn.send("PRIVMSG {} :{} {} {}".format("NickServ", "IDENTIFY", botnick, password))
            time.sleep(10)
    ircconn.send("JOIN {} \n".format(channel))  # Joins channel

The raw message for the freenode NickServ acknowledgement is

:NickServ!NickServ@services. NOTICE LibO_welcome :You are now identified for LibO_welcome.

Edit: probably a better way would be to start using SASL authentication.

Bot died after observing this quit message: Quit: Odch�z�m

This was the console output:

PING :orwell.freenode.net
Traceback (most recent call last):
  File "bot.py", line 328, in <module>
    sys.exit(main())
  File "bot.py", line 318, in main
    msg_recv = msg_handler(ircsock)  # gets message from ircsock
  File "bot.py", line 129, in msg_handler
    new_msg = ircsock.recv(2048).decode('utf-8')  # receive data from the server
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 55: invalid continuation byte

I ran into this case:

1. Welcomebot joins a fresh channel
2. One day, there is a netsplit (or Matrix bridge falls down) and many regulars from the channel re-join at once
3. Welcomebot gives dozens of welcomes in a row!

Maybe have a limit that if a welcome wait-time is triggered, only one extra welcome is allowed to be triggered during the original time window.

We have
nick = nick.rstrip('_1234567890')
It might be good to also ignore _away occurring at the end of nicknames. Sometimes people might join the channel with that in their nick.

Currently with 1 greeter the bot just says (like ).

This should be fixed with something like

if len(self.greeters) > 2:
    greeters_string += ", and {}".format(self.greeters[-1])
elif len(self.greeters) == 2:
    greeters_string += " and {}".format(self.greeters[-1])
else:
    greeters_string = "{}".format(self.greeters[-1])