qbox-project / qbx_vehiclekeys

qbx-vehiclekeys

Vehicle Keys System For QBOX

qbx_vehiclekeys's Issues

Error in VehicleKeys w/ Newest Core Changes

Summary

Error in VehicleKeys w/ Newest Core Changes

Reproduction

Line 52: local citizenid = QBX.Functions.GetPlayer(source).PlayerData.citizenid

Expected behavior

No Error

Actual behavior

Error

Additional context

No response

Last Updated

2 days ago

Custom Resources

No

Resource Rename

qbx_vehiclekeys

Spamming lock and unlock causes issues

Summary

if you spam lock and unlock it causes performance issues

Reproduction

Spam lock/unlock

Expected behavior

not cause performance issues

Actual behavior

causes performance issues

Additional context

probably interactsound related issue as resmon on xsound/interactsound skyrockets

Current Version

current

Custom Resources

no

no export haskeys

Additional context

Last Updated

today

Custom Resources

none

Resource Rename

none

Losing Keys After Reconnecting

Summary

Facing difficulties with key retention after reconnecting

Reproduction

1. Use personal vehicle
2. Disconnect from the server
3. Log in back to the server
4. The vehicle is locked, and you get a notification that you don't have keys

Expected behavior

When you log in again you should have the keys to your vehicle

Actual behavior

The vehicle is locked, and you get a notification that you don't have keys

Additional context

No response

Last Updated

Today

Custom Resources

None

Resource Rename

No

Game Design Improvements for vehicle keys

The problem

Suggesting these features be added or reworked:

qb-vehiclekeys feature set is antiquated/needs to be added to and improved.

Ideal solution

• Proper car starting animation (depending on vehicle, motorcycle, cars, etc)
• engine start sound (most key resources don't play the full engine start up sound on restart
• give key command
• % chance world spawn cars are locked in world (config option)
• List in config of vehicles that require lockpicks to unlock (ox lib minigame)
• vehicles that require an advanced lockpick to unlock (harder minigame than the lockpick)
• List of Cars that can't be unlocked at all
• Cars with no locks/accessible to everyone (for vehicles like wheelchairs, bicycles, etc)
• List of weapons that can and can't steal keys from drivers, with a setting for chance that some weapons are more likely
• set change that peds will drive off: for example, 25% chance a ped tries to drive off, 10% they get and fight, 65% they give you their keys, or they try to escape
• Police alert settings: i.e. chance to alert police when lockpicking or hotwiring
• shared keys list for jobs
• Lock PD/EMS/Job vehicles automatically on leaving cars
• Config option to allow people to get into cars that are turned on and drive off
• Remote car start config option (turn off remote start as an option)
• Whitelist or "whitelist" of vehicles with no doorlocks, but need to be ox_lib circle game/lock picked to to unlock. Useful for things like motorcycles, which don't have doors but should require lockpicking.

Alternative solutions

N/A

Additional context

These changes would make qbx_vehiclekeys a much better resource. As it stands, qb-vehiclekeys has a pretty antiquated design and should have features added to make it more modern and useable.

I have some of these changes in the version of qb-vehiclekeys that popcorn rp uses, although it's not the greatest implementation and most of it is janky.

[SUGGESTION] Plates prefixes in areKeysJobShared

The problem

Jobs such as lspd have vehicles with a specific plates prefix. It may be worth giving shared keys based on this prefix, not just for specific vehicle models.

Ideal solution

All vehicles in the police garage have shared keys.

Alternative solutions

No response

Additional context

Is there a chance for a private vehicle to appear with a plate that has the prefix lspd?

qbx_vehiclekeys/client/functions.lua

Line 261 in 1b210e1

function public.areKeysJobShared(vehicle)

[BUG] Give a vehicle keys to all players in the vehicle

The problem

At this moment it isn't possible to give the keys to everyone in the car by command.

Ideal solution

Need to determine if we want to keep the function of giving keys to everyone in the vehicle.

Alternative solutions

No response

Additional context

No response

feat: Remove unused functions

The problem

There are many unused functions in the resource. Maybe it's time to throw them away?

Ideal solution

Solved lint errors.

Alternative solutions

No response

Additional context

[SUGGESTIONS]

The problem

QBus copied NP even though it's dumb and really bad

Ideal solution

Use StateBags

If car is locked and lockpick then open doors

if you own the car then you can lock/unlock

don't let vehicles turn off automatically

and a command to give the car to someone else i guess

that's it

Alternative solutions

No response

Additional context

No response

[BUG] impossible carjacking

Summary

All vehicles flee during hijacking attempt

Reproduction

Try to hijack a vehicle with a weapon

Expected behavior

Some peds will stay with their hands up

Actual behavior

All the peds are running away.

Additional context

No response

Current Version

b89be3a

Custom Resources

I encountered a problem like this. is it not using modules/utils?

Summary

nil value global GetPlate

Reproduction

Expected behavior

...

Actual behavior

...

Additional context

...

Current Version

...

Custom Resources

qbx_vehiclekeys

Change to native audio

The problem

Uses interact sound

Ideal solution

Use native audio

Alternative solutions

N/A

Additional context

N/A

Getting a notification that i received the vehicle keys, but i did not.

Summary

Getting a notification that i received the vehicle keys, but i did not.

Reproduction

Using The Impound/Garage, or using any job garage using wasabi script, i have set up the exports correctly.

Expected behavior

For it to give me the keys, but it just displayed a notification and didnt give me the keys

Actual behavior

Apparently "Gave me the keys" But it seems to not work at all.

Additional context

Video of it:
https://streamable.com/medk3o

Last Updated

today

Custom Resources

Nope, i only have my locales/jobs replaced, i have all latest resources of qbox.

Resource Rename

no

Broken alarm on hot-wiring

Summary

During the theft, the vehicle does not make any sound.

Reproduction

1. Breaking into a vehicle that is not owned,
2. Hot-wiring the vehicle

Expected behavior

Some kind of alarm sound

Actual behavior

Silence

Additional context

This happened after the approval of this PR.

Current Version

v1.0.0

Custom Resources