qcha / drp Goto Github PK

Class: com.github.aarexer.qcha.drp.deserializers.DsvFileIterator

Problem: Need to write unit-tests for class.

Test cases:

1. resource is null
2. resource properties is null - each property should has own test.
3. File by uri in resource doesn't exist.
4. File exists, but empty.
5. File exists and has data, but it's not dsv.
6. File exists and has right data.

Class: com.github.aarexer.qcha.drp.model.DsvFileResource.

Problem: We need to Builder, which can put default variables in some fields of class. For example - default line separator.

Need to rewrite handling exceptions in deserializers/iterators.

Class: com.github.aarexer.qcha.drp.model.DsvFileResource.

Problem: We need write unit tests for filling check.

Cases:

1. Filling fields and check it.
2. Test default values.

Need to configure logger and add log debug, error and etc messages in project code.

Need to understand - what to do with null check for preferences arg.

It's bad to create new connection to ftp server every time when you need resource.
It will be good idea to have a connection pool, from which we can get connection.

library:
org.apache.commons.pool2

Problem:
Data from these classes are copy-paste from CompressorStreamFactory and ArchiveStreamFactory.
It's bad design - When the library(apache.commons-compress) changes, we will not get these changes and our library will not work correctly.

Need to think how we can fix it.

When we work with URI - we can resolve type of schema(ftp, ftps local and etc.).
And type of file.
Need to write class which can resolve what deserializer and connection should be use.

Testing ftp connections with ftp mock.

library:
org.mockftpserver.fake.FakeFtpServer

As i can see - we need to use some generator for DsvResource in tests.

I think, that generator should have static methods for generate DsvResource:

1. generate(uri) - generate resource with given uri.
2. generate(uri, delimiter) - generate resource with given uri and delimiter.
3. generate(uri, delimiter, quotes) - generate resource with given uri and delimiter, quotes.

and etc.

It needs for testing deserializers.

Awesome code in ftp package - a lot of fixme and good stuff!
Solve it.

We need write good readme.md file and present our library.
With examples of using and etc.