quotidian-ennui / bitbucket-pr

Huh; project manager first, not developer first

About Me

Sometimes I have things to say; you can find my assorted ramblings for your reading pleasure here.

I have excellent knowledge of many different technology stacks, and can recognise potential weaknesses and design effective solutions. I understand the interplay between new features, system complexity, and technical debt, and can make trade-offs among them effectively to deliver the solution you need.

---

bitbucket-pr's Issues

error output is not informative, since there is none.

# Note that all these operations took over much longer than expected
bsh ❯ bb-pr squash-msg
---
feat!: add truncate to REST endpoints with backing database (pull request #117)
...
---
is now in your clipboard

Ubuntu-22.04 took 31s
bsh ❯ bb-pr close-branch
close_source_branch now true

Ubuntu-22.04 took 4s
bsh ❯ bb-pr squash-merge
Operation failed...

Ubuntu-22.04 took 1m36s
bsh ❯ bb-pr squash-merge
>>> No PR

Ubuntu-22.04 took 22s

So the attempt to squash merge failed, but it was actually squash merged (since I checked bitbucket manually afterwards).

Probably because the HTTP response here, doesn't conform to expectations which means we just get nulls which don't get emitted ?

bitbucket-pr/bb-pr

Lines 281 to 287 in 13182b7

	http_code=$(curl -X POST -sSL --user "$CURL_AUTH" -H "$CURL_HEADER_ACCEPT" -H "$CURL_HEADER_CTYPE" "$pull_request_url" "--data" "@$WORK_FILE" -o "$SQUASH_MERGE_OUTPUT" -w "%{http_code}")
	if [[ "$http_code" -ge "400" ]]; then
	#shellcheck disable=SC2002
	cat "${SQUASH_MERGE_OUTPUT}" | jq --raw-output "$failure_jq_transform" | column -s "|" -t -N "ID,STATE"
	echo Operation failed...
	exit 1
	else

Deal with merge checks failures

When merge check has failed and you run squash-merge, the errors are lost in a curl error.

{
  "type": "error",
  "error": {
    "message": "3 failed merge checks",
    "fields": {
      "merge_checks": [
        "At least 1 approval",
        "No failed builds on last commit",
        "At most 1 commit behind destination"
      ]
    }
  }
}