GithubHelp home page GithubHelp logo

Comments (2)

thejackshelton avatar thejackshelton commented on June 12, 2024

So you're saying the <Link /> component should automatically handle the inclusion of the base URL in the href? Or the fact that the tests include it in the link href should be removed?

On a new Qwik City project, adding the following seemed to work fine automatically:

  return renderToStream(<Root />, {
    manifest,
    ...opts,
    // Use container attributes to set attributes on the html tag.
    containerAttributes: {
      lang: "en-us",
      base: "/test-base/",
      ...opts.containerAttributes,
    },
  });
      <Link href="/about">TO ABOUT</Link>

would still take me to the about page.

image

from qwik.

JerryWu1234 avatar JerryWu1234 commented on June 12, 2024

tests include it in the link href should be removed?

I think it should be removed. What do you think?

On the other hand.
If the user sets a base in vite.config.js. Perhaps there are some conflicts in both properties.

from qwik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.