r-medina / go-uber Goto Github PK

Instead of using the default http client, you should expose that as a public variable, that way a user can substitute it with their own client.

For get and generating urls

We should start thinking about getting a token and testing the integration with the Uber API

As of now, the tests are designed only for "perfect" requests. That is, ones in which the Uber API is available and the client request is properly made.

Also, do we need tests for the helpers and authorization tools? Those should be tested via our more generalized tests. Thoughts?

duration and distance response variables from price estimate endpoint:
https://developer.uber.com/v1/endpoints/#price-estimates

promotion endpoint:
https://developer.uber.com/v1/endpoints/#promotions

If the Uber api returns an error, we wouldn't parse it properly. Non-2xx responses do not produce an error.

I'm making an UberError type that implements the error interface and parses the body of a failed request to the api to generate a worth-while error.

The exported methods should probably not return a fancy error type (as that would be too different from normal golang flow).

Currently, before a client can use the user info endpoints (history and profile) they must go through a three step authentication with uber (https://developer.uber.com/v1/auth/#oauth-2-0) which results in them receiving an access token which they use to access these endpoints.

This issue is to figure out a way to abstract/hide this from the client, maybe by changing some construction parameters and authentication logic being handled in the construction.

Uber recently announced v1.2 endpoints for the Rides API. The following changes would be required to upgrade:

1. API base URL would need to reflect the version bump: https://api.uber.com/v1.2/. Sample endpoint.
2. A new ride request flow for upfront prices should be implemented, as described here
3. All usage of rate limiting headers should be removed. The headers are deprecated with v1.2. A new endpoint to meet the needs will be created. Here are the impacted headers: X-Rate-Limit-Limit, X-Rate-Limit-Remaining, X-Rate-Limit-Reset.

Hey, i'm using your library and I found that the uri that your library generated is invalid. Might want to look into this.

Not sure what your plan is but this library won't work in google app engine since url fetches are done using the urlfetch instead of &http.Client{}

MIT or Apache? @r-medina @asubiott