GithubHelp home page GithubHelp logo

Comments (5)

timelyportfolio avatar timelyportfolio commented on July 24, 2024

@tim-salabim, I believe I have been able to reproduce the error from your example. There seems to be two issues. The first is merging with tibble-based sf, which I will fix as quickly as possible. The second is editing any polygon with holes; without Leaflet/Leaflet.draw#146 I am not sure we can correct this problem.

from mapedit.

timelyportfolio avatar timelyportfolio commented on July 24, 2024

r-spatial/sf#391 more thoroughly describes the tibble issue.

timelyportfolio@df77aaf resolves issue 1 above.

Leaflet.draw with holes remains...

from mapedit.

tim-salabim avatar tim-salabim commented on July 24, 2024

Partially cross-posting from #29:

I noticed that hole vertices become un-editable when you move the enclosing polygon. Also, deleting hole vertices is a final deletion, i.e. it doesn't seem to respect pressing cancel to undo stuff. In any case, I think this is all not our problem at this point as this all stems from the Leaflet.Draw plugin if I'm not mistaken.

from mapedit.

timelyportfolio avatar timelyportfolio commented on July 24, 2024

@tim-salabim, your statement is correct. I will leave this open though as a reminder to check back on Leaflet.draw pull and also explore other potential plugins.

from mapedit.

timelyportfolio avatar timelyportfolio commented on July 24, 2024

I believe we can safely close this now with the addition of leafpm. Please reopen if we should continue the discussion.

from mapedit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.