Comments (21)
For now, I will add logic to get @map
if mapview
is provided for map
.
from mapedit.
e6ba857 is a first trial for user defined bg map provision
from mapedit.
This makes very good sense and aligns with editMap
approach. Also, I much prefer this over trying to provide arguments for map customization within editFeatures
/editMap
.
Off topic, but it seems editMap
is quickly becoming more of an internal function, which is not something I expected at the outset :)
from mapedit.
I think we can also think about another approach here. Using editMap
to edit features on an existing map, but then we would somehow need to specify which groups of the map to activate for editing. If that is an possible that would be a similarly nice option. I guess I approach things more from a (spatial) data perspective, hence editFeatures
& selectFeatures
just seem more natural to me. Though I am sure there are just as many people who would approach these things from a map-based point of view where editMap
would be the obvious choice.
from mapedit.
We could revisit the idea of editMap.sf
.
from mapedit.
Also, I think that the principle difference between editMap
and editFeatures
should be the x
to be edited. A map in the former, a feature in the latter.
from mapedit.
In any case, we should enable user supplied maps
from mapedit.
Would you like me to extend the functionality in *Features
to use +
or addFeatures
in the case where user supplies mapview
map?
from mapedit.
addFeatures
would be better as it can also be used for leaflet map. +
is only defined for mapview objects
from mapedit.
Don't do this since it crashed my session, but I just discovered issue in case of editFeatures(breweries, mapview(breweries)
. Should this be handled in mapview::addFeatures
or mapedit
?
from mapedit.
What's the issue? I had no problems with this example (with a fresh devtools::install_github("timelyportfolio/mapedit")
from mapedit.
What happens when you mapview(breweries)@map %>% addFeatures(breweries)
?
from mapedit.
from mapedit.
This looks fine to me. Identical to mapview(breweries)@map %>% leaflet::addCircleMarkers(data = breweries)
from mapedit.
@timelyportfolio Is this still causing problems on your side?
from mapedit.
I guess my machine was just tired that day, since I no longer get problems. However, should we attempt to handle the case where x
in editFeatures
is already in the map
provided like in editFeatures(breweries, mapview(breweries)
?
Honestly, I sort of like the duplicated points from the example above that we can use as reference as we edit, so maybe we just assume user intentionally duplicated.
from mapedit.
Yes, I don't think we should try to be smarter that necessary. And I am sure there will be cases where scenarios like this one are completely intentional.
from mapedit.
Ok, going to close. Please reopen if there are lingering unresolved issues.
from mapedit.
So, there are no lingering issues somewhere in mapview regarding this? I'd like to submit mapview to CRAN very shortly (possibly tonite) but want to make sure that mapedit will work as expected with that version.
from mapedit.
I think it is good to go. After mapview up on cran then we can focus on mapedit cran submission. I have been running checks on eac change for the last two weeks so hopefully no surprises.
from mapedit.
That was my thinking. I just submitted to winbuilder, so let's see...
from mapedit.
Related Issues (20)
- Load back previously drawn polygons to mapedit map
- editor Module in demo example fails in mapedit 0.6.0 but works in 0.5.0 HOT 2
- selectFeatures draws on world map even if crs = NA (for mode = "click" only) HOT 7
- New feature to download edited data HOT 2
- Click events for leafpm editToolbar buttons HOT 5
- leafpm removes markers added using leafletProxy HOT 2
- Use raster in base map with editMap HOT 2
- Issues installing r-spatial packages HOT 1
- is there a way to display only some of the tools HOT 2
- Is this package still actively developed? HOT 1
- Strange case of difficult viewing HOT 7
- Integration leafmap new feature HOT 17
- 'initBaseMaps' and 'mode = "click"' for selectFeatures
- Warning: `select_()` was deprecated in dplyr 0.7.0. HOT 5
- selectFeatures error possibly related to "draw" mode HOT 3
- mapedit installation on Google colab
- Error triggered by "Clear All" when there are three or more drawn objects.
- Coordinates using editMap() with addRasterRGB() are wrong HOT 3
- mosaic_view() running problem HOT 3
- callModule(editMod, ...) only returns the geometry
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapedit.