Comments (5)
Very happy it's just a signal and not an error :)
from mapedit.
@tim-salabim I see now. I missed your commit and misunderstood thinking we were discussing in theory. Adding a JavaScript warning should be fairly straightfoward. I will leave this open as a reminder to work on this once we have finished the prioritized open items.
from mapedit.
@timelyportfolio an attempt at signaling when features are drawn in a location outside the standard longitude range between -180 & 180. This now emits a warning which is possibly highlighted using crayon (if available) in nasty red background with white text :-) .
In my opinion, this is sufficient, but we could make sure to mention somewhere that this warning is generated if features are drawn outside sane bounds (which, for whatever reason, is allowed by leaflet).
Any other suggestions? Thoughts?
from mapedit.
@tim-salabim would this require a dependency on crayon
? Are you thinking an error from JavaScript or R
? Assuming R
, and in this case we could add a test when we mutate the state based on Leaflet.draw
events. Or would you rather delay the test until completion?
from mapedit.
@timelyportfolio crayon
is in Suggests:
with a if (requireNamespace("crayon"))
conditional on the warning. In my experience, I pay even less attention to console output in shiny
apps than in interactive mode, that's why I thought highlighting is helpful in this case.
With the above commit, this warning is emitted every time (part of) a feature is drawn outside -180 / 180 longitude. I think this is what you mean with "a test when we mutate the state based on Leaflet.draw events", right? If not, I think I need more clarification.
Regarding a JS warning, I think it would be great as it would provide more direct feedback especially when working in the browser. Though, I would only do this if we can assure that it doesn't interrupt interaction too much (people may intentionally want to draw outside standard bounds, who knows). I first thought of a alert
call, but this would be really annoying I think. If we can find a good place in the window/map to place such a warning, then I would say it is desirable to emit directly via JS (potentially keeping the R warnings as well). But this is something that I would not know how/where to implement.
from mapedit.
Related Issues (20)
- Exporting selected map data in Shiny HOT 3
- Edit existing feature within Shiny and save HOT 7
- Is there a way of flushing the old data from $finished when using singleFeature=TRUE mapedit in a Shiny app? HOT 9
- Load back previously drawn polygons to mapedit map
- editor Module in demo example fails in mapedit 0.6.0 but works in 0.5.0 HOT 2
- selectFeatures draws on world map even if crs = NA (for mode = "click" only) HOT 7
- New feature to download edited data HOT 2
- Click events for leafpm editToolbar buttons HOT 5
- leafpm removes markers added using leafletProxy HOT 2
- Use raster in base map with editMap HOT 2
- Issues installing r-spatial packages HOT 1
- is there a way to display only some of the tools HOT 2
- Is this package still actively developed? HOT 1
- Strange case of difficult viewing HOT 7
- Integration leafmap new feature HOT 17
- 'initBaseMaps' and 'mode = "click"' for selectFeatures
- Warning: `select_()` was deprecated in dplyr 0.7.0. HOT 5
- selectFeatures error possibly related to "draw" mode HOT 3
- mapedit installation on Google colab
- Error triggered by "Clear All" when there are three or more drawn objects.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mapedit.