r3-os / r3 Goto Github PK

Used by the following actions:

• r3-os/actions-rust-toolchain@patch/pr-209 https://github.com/r3-os/r3/actions/runs/3450536746/jobs/5759188944#step:3:45
  • actions-rs/toolchain#221
• actions/cache@v2 https://github.com/r3-os/r3/actions/runs/3450536745/jobs/5759188976#step:5:6
• LouisBrunner/[email protected] https://github.com/r3-os/r3/actions/runs/3450536745/jobs/5759188976#step:8:11

rust-lang/rust#97027

badges/shields#8671

1. Copy trait bound is not sufficient for us to safely transmute from &Head. Suggest to use trait bound such as Pod.
2. Transmute has an overloaded return type. If you do not specify the return type it may produce a surprising type to satisfy inference¹.

r3_core::utils::ZeroInit should be replaced by bytemuck::Zeroable. The latter is derivable (which helps us remove some unsafe impls) and has a better Rust ecosystem compatibility.

Zeroable is missing the following implementations:

• core::atomic::Atomic{Bool,{U,I}{8,16,32,64,size},Ptr<impl Sized>} (Lokathor/bytemuck#74)
• Option<fn(Args...) -> R>
• Option<&[mut ]_>
• UnsafeCell<impl Zeroable> (Lokathor/bytemuck#148)
• [impl Zeroable + Sized] Zeroable requires Sized

is fixed. by rust-lang/rust#101989

https://deno.com/blog/v1.28

Having a local trait Init is problematic for a number of reasons:

• Init is implemented on some external types, such as ArrayVec and TokenLock, for internal use. However, Init is also exposed to the user to allow for its use with r3::hunk::Hunk, giving access to these internal-use-only trait implementations. This means removing these trait implementations is a breaking change.
• Implementing Init in an external crate requires a dependency on r3 even if the rest of r3 is not needed at all.

The best course of action is to replace Init with something else provided by an upstream crate or a language feature.

Raw interface specificity:

• Should the priority-based scheduling be enforced at API level? How should the test suite handle kernels without strict scheduling?
• Some kernel implementations may prefer not returning BadId and causing an undefined behavior instead.

Raw interface extensibility:

• MutexProtocol should be non_exhaustive? How is the kernel supposed to deal with unknown values?
• The same goes for QueueOrder
• Multi-processing
• Some properties added to a Bag might be unsafe to ignore. How can we ensure the safety? What properties might fall under this criterion?

API design:

• Implement object safety
• The definer methods should be named define to make room for runtime construction.
• r3::kernel::Cfg isn't a pretty name.
• Kernel is not a raw trait. KernelMutex is a raw trait. But they are both in traits.
• Is it really a good idea to require application code to use raw traits in trait bounds but use Kernel for global operations? Kernel being a kitchen sink is actually consistent with higher-level kernel object wrappers (like how Task::set_priority is bound by System: raw::KernelTaskSetPriority). But the real problem is that the raw traits are supposed to be bound by kernel-side semver guarantees.

r3_kernel:

• r3_kernel::CfgBuilder is an awful name.

Documentation:

• Update CHANGELOG.md
• Define the versioning scheme

https://github.com/bitflags/bitflags/releases/tag/2.0.0

Better to bundle this with other breaking changes, such as #14.

Used by the following actions:

• actions/checkout@v2 https://github.com/r3-os/r3/actions/runs/3450808912/jobs/5759621733
• actions-rs/clippy-check@v1 https://github.com/r3-os/r3/actions/runs/3450808912/jobs/5759621839
  • actions-rs/clippy-check#169
• actions-rs/cargo@v1 https://github.com/r3-os/r3/actions/runs/3450843035/jobs/5759703459
  • actions-rs/cargo#216
• r3-os/actions-rust-toolchain@patch/pr-209

Such as https://github.com/r3-os/r3_port_rx

Kernel objects should be able to have names for runtime inspection and to improve the configuration-time error reporting.

(It'd be ideal if we could also track their definition sites, but that would require std::backtrace::Backtrace::frames to be usable in const fn.)

https://github.com/r3-os/r3/actions/runs/4430420543/jobs/7822620604

Run LouisBrunner/[email protected]
  with:
    token: ***
    name: Size report: qemu_mps2_an505 --arch cortex_m4f
    output: {"summary": "Test suite size report"}
  
    output_text_description_file: size-report.md
    conclusion: success
    status: completed
Error: Resource not accessible by integration

Please note that with rust-lang/rust#94901 merged, ~const Drop bounds should be changed to ~const core::marker::Destruct. Sorry for the inconvenience.