radhifadlillah / duit Goto Github PK

Greetings!

I recommend that your project is not depending on one specific RDBM like mySQL but rather make it somehow compatible with many RDBMS like Postgress, mySQL, rqlite, sqlite3, etc...

This is a more promissing design decision.

Best regards

Hey, that's a great project. I pulled it and playing with it.

I see that you are using cobra package. To me, this project is a server application and not a CLI application, so cobra seems like an overkill to read 2 arguments and display a help message. I replaced it with the flag package and removed cobra from dependencies.

You are also using toml for reading configuration data. Your data is fairly simple , so I replaced toml with yaml and removed the toml dependency. Yaml still adds a dependency to go.mod, but it's an official one, so less maintenance.

Those changes really does not affect features at all but Go is famous for it's standart library, so it seemed liked a good idea.

What do you think ?