raeldc / jelly-auth Goto Github PK

Steps to reproduce:

1. Comment out the (mt_rand(1, 100) === 1) conditional.
2. Call new Model_Auth_User_Token;

Result:

Database_Exception [ 1103 ]: Incorrect table name '' [ DELETE FROM `` WHERE ``.`` < 1277913159 ]

I've worked around this by moving the garbage collection to the constructor. There's a patch here should you be interested.

Cheers,

Aron

While running "git submodule update --init" I get:

fatal: reference is not a tree: 5fe550860cef089a54e071ac2936bd99cea54bf5
Unable to checkout '5fe550860cef089a54e071ac2936bd99cea54bf5' in submodule path 'modules/jelly-auth'

related:
http://autonomousmachine.com/2009/2/7/git-error-fatal-reference-is-not-a-tree-error

When jelly-auth declares a not_empty rule, the correct syntax is 'not_empty' => NULL, but jelly-auth uses 'not_empty' => array(TRUE), which is incorrect.

Here are three places it's used incorrectly:

• http://github.com/raeldc/jelly-auth/blob/master/classes/model/auth/user.php#L18
• http://github.com/raeldc/jelly-auth/blob/master/classes/model/auth/user.php#L27
• http://github.com/raeldc/jelly-auth/blob/master/classes/model/auth/user.php#L38

I'm not sure if this syntax problem exists elsewhere too.

Are you agree with adding the i18n call to 'password'?
$array->error($field, 'matches', array('param1' => __('password')));

The comments on Model_User_Token have not been modified from Sprig-Auth, so that the Sprig Auth package appears in the API browser when using Jelly Auth.
/**

• Sprig Auth User Token
• @Package Sprig Auth
• @author Paul Banks
  /
  should be:
  /*
• Jelly Auth User Token
• @Package Jelly Auth
• @author Israel Canasa
  */

This would allow you to login using any parameter supported by the unique key method. For example an email address. The ORM Auth module currently supports this.

Update line 264 in classes/auth/jelly.php to use Jelly_Builder::load() which uses the :unique_key parameter internally.

// From
$current = Jelly::select('user')->where('user', '=', $user)->limit(1)->execute();

// To
$current = Jelly::select('user')->load($user);

Cheers,

Aron

The auth module has committed new functionality that breaks with the current jelly-auth. I've forked the repos and made some changes in classes/auth/jelly.php.

I think I've also done a pull-request.. first time for me, that's why I've also added this issue :)

Hi,
Within the class Auth_Jelly
you refer to $this->_session and $this->_config ... why?

In Kohana_Auth, the references should be: $this->session and $this->config

Thanks