rafaelcamargo / dollert-extension Goto Github PK

Avoid build passing if unit test coverage is less than 100%

Suggestion

Considering that user has the following alerts saved: 3.65, 3.70. Dollert should notify when dollar reaches 3.65. On the next request, Dollert should not notify the user if the dollar value continues the same. So, in this case, the user only will get notified again if dollar reaches 3.70. This exact same behaviour will be applied to 3.70.

The other one for some reason went to the darkness. Update to a new one.

When opening popup, a *loading now value..." should be show. Once the value is fetched, remove loading message and show the information as the following mockup:

A new color variable should be created for the green color: #58AE30

When, for some reason, the API we are currently using takes too long to respond (if it responds...) users get stuck in a "Loading value..." message.
The ideia is set a timeout of 5 seconds and show some failure message for those cases. Doing so, users don't get stuck with that "Loading value..." message anymore.

Create the basic workflow

i.e.: is wrong. Change it to e.g.:

Current API is often failing on get USD value.

Popup:

Desktop Notification: