GithubHelp home page GithubHelp logo

Add order by about hn-cli HOT 10 CLOSED

rafaelrinaldi avatar rafaelrinaldi commented on July 20, 2024
Add order by

from hn-cli.

Comments (10)

rafaelrinaldi avatar rafaelrinaldi commented on July 20, 2024

@erickbelfy Hey Erick! Yeah, I thought about it once (see #1 😆) and even started to work on it but I just dropped the feature completely. Even though the whole idea of this program is to reflect whatever is on the front page of HN, I see this feature as a nice to have.

You can definitely start working on it if you feel like. The only thing I ask is to trigger this by reading from a flag and not something that the user can do when the program is already running.

Thanks for your interest!

from hn-cli.

erickbelfy avatar erickbelfy commented on July 20, 2024

Sure @rafaelrinaldi i was wondering if i could implement a new flag like --order-by=<column>. It works for you?

from hn-cli.

rafaelrinaldi avatar rafaelrinaldi commented on July 20, 2024

@erickbelfy Hum, I think --latest should suffice since ordering by anything other than the submission date doesn't really make sense nor it's useful. How does that sound?

from hn-cli.

erickbelfy avatar erickbelfy commented on July 20, 2024

Sounds really good @rafaelrinaldi do you have any preferences about unit tests? Because i didn't see any unit test cases at your code yet.

from hn-cli.

rafaelrinaldi avatar rafaelrinaldi commented on July 20, 2024

@erickbelfy I've a local branch with some basic tests that I was planning to add but haven't had the time to publish them yet. Is this an issue?

from hn-cli.

erickbelfy avatar erickbelfy commented on July 20, 2024

Not at all, i just would like to know what is your suit test case to follow your standards, but i can do the same.

from hn-cli.

erickbelfy avatar erickbelfy commented on July 20, 2024

But we should consider add this for future implementations, start an documentation about how users can contribute to the project :)

from hn-cli.

rafaelrinaldi avatar rafaelrinaldi commented on July 20, 2024

@erickbelfy Yup, it's on the pipeline already! Just haven't had the time to tackle it as I said. I can ping you when there's a somewhat decent version if you want to.

from hn-cli.

erickbelfy avatar erickbelfy commented on July 20, 2024

Absolutely, i'd like to keep updated about the project, that's a pleasure to help and learn more about it. ;)

from hn-cli.

rafaelrinaldi avatar rafaelrinaldi commented on July 20, 2024

@erickbelfy Glad to hear 😄

terrific

from hn-cli.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.