rafek1241 / rebus.serializer.xml

XML serializer built on top of NewtonSoft.JSON for ReBus library

rebus.serializer.xml's Issues

Introduce type and namespace storage strategies

Give a possibility for the user to decide how namespace should be stored in a serialized message. Deserialization should remain the same and use all possibilities.

Possible strategies:

• message headers (extensions)
• XML root container attributes
• Both

Fix BaseType order of attributes.

In NServiceBus deserialization order of xml attributes in root container is important.
Expected:

<Messages xmlns:xsi="..." xmlns:xsd="..." xmlns="..." xmlns:baseType="..." xmlns:baseType1="..">

Actual:

<Messages xmlns:baseType="..." xmlns:baseType1=".." xmlns:xsi="..." xmlns:xsd="..." xmlns="..." >

Include base types in XML during deserialization of message

if the deserialized type cannot be mapped to the exact type we should try out the base types from XML root container attributes.

It's dependent of #2 .

Create documentation for serializer

Create documentation for XML serialization package.

• Describe how it works exactly, why newtonsoft.json is being used, and how it can be used?
• Example scenarios.
• Describe message headers that are set by serializer & possible options for XML serializer.
• Unsupported section

Include base types in XML during serialization of message

Actual:

<RootContainer xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns="http://tempuri.org/sometype">
....
</RootContainer>

Expected:

<RootContainer xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns="http://tempuri.org/sometype" xmlns:baseType="NServiceBus.ICommand" xmlns:baseType1="NServiceBus.IMessage">
....
</RootContainer>

Explanation:

NServiceBus in older versions (I don't know how it works now) parsed XML objects to specific classes by using XML namespaces from their root container attributes. I want to have it to give a possibility for NServiceBus to read that messages.

Introduce fluent configuration

Currently, there is an options class that contains all settings and it is included in the extension method. It should be possible to set it up fluently by method chaining.

Current:

//rebus configuration
...
                   .Serialization(
                        r => r
                            .UseXmlSerializing(
                                logger,
                                new XmlSerializingOptions()
                                {
                                    IncludeNamespace = true,
                                    DefaultNamespacePrefix = "http://tempuri.net"
                                }
                            )
                    )

Expected:

                   .Serialization(
                        r => r
                            .UseXmlSerializing()
                                .WithLogger(logger)
                                .IncludeNamespace()
                                .WithNamespacePrefix("http://tempuri.net")
                    )

and

var config = new XmlSerializerConfig()
                                .WithLogger(logger)
                                .IncludeNamespace()
                                .WithNamespacePrefix("http://tempuri.net");

...
                   .Serialization(r=> r.UseXmlSerializing(config))