rafgraph / detect-touch-events Goto Github PK

ReferenceError: window is not defined
at Object.update (/Users/praneetaj/stash/FE/home-details-components/node_modules/detect-touch-events/lib/index.js:8:9)

It should check for
typeof window !== 'undefined'
instead

Possibly something to clarify in the README: navigator.maxTouchPoints has nothing to do with the Touch Events spec. It is defined in the Pointer Events spec https://w3c.github.io/pointerevents/#dom-navigator-maxtouchpoints

Of course, this muddies the issue a bit since the name of this whole repo suggests it's about TE. perhaps the name should be generalised to just detect-touch-capability or similar?

Related to #2 - currently, maxTouchPoints returns undefined if the legacy TE detect returns false. However, navigator.maxTouchPoints can indeed be defined (and even have value > 0) when no TE support is present, since it's part of the Pointer Events spec. (case in point: see https://patrickhlauke.github.io/touch/tests/pointer-multitouch-detect.html in a recent stable Chrome build)

Worth noting that the more modern way to detect the presence of touch event API would be to test for window.TouchEvent. At the same time worth noting that, at least as far as Chrome is concerned, this will return true even if there is no actual touchscreen at browser startup - which makes sense if the intent is indeed to test the presence of the API / the capability. See https://lists.w3.org/Archives/Public/public-touchevents/2016Dec/0007.html for further info