rahul-thakoor / embedded-graphics-web-simulator Goto Github PK

Hi! Love your work <3

I'm using embedded-graphics 0.8 but embedded-graphics-web-simulator only supports this in repo. I think it would be nice to put out another release.

Hello!

I use your simulator for testing my drawing function.
The code below draws an image on the center of the display.

fn draw_image<D>(&raw_image: &ImageRawLE<Rgb565>, display: &mut D) -> Result<(), D::Error>
where
    D: DrawTarget<Rgb565>,
{
    use core::convert::TryFrom;
    let (w, h) = display.size().into();
    let (iw, ih) = (raw_image.width(), raw_image.height());
    let (x, y) = (
        i32::try_from(w / 2 - iw / 2).unwrap(),
        i32::try_from(h / 2 - ih / 2).unwrap(),
    );
    let top_left = Point::new(x, y);
    let image = Image::new(&raw_image, top_left);
    image.draw(display)
}

But I got different outputs according to the scale of display.

Current implementation of WebSimulatorDisplay looks to change its size by output_settings.

https://github.com/meganetaaan/embedded-graphics-web-simulator/blob/0158a015e0295a62db85c293590f7553fd289b99/examples/basic/src/lib.rs#L40

I think it might be better the display.size returns its original (not scaled) display size?

Thank you!