GithubHelp home page GithubHelp logo

railslove / rcvr-app Goto Github PK

View Code? Open in Web Editor NEW
41.0 6.0 6.0 8.54 MB

recover provides localities a privacy-compliant, safe, and easy way for their guests to check in. See https://www.recoverapp.de/ for more details.

Home Page: https://recoverapp.de

License: GNU Affero General Public License v3.0

JavaScript 2.21% TypeScript 96.11% CSS 0.24% C++ 0.93% Meson 0.19% HTML 0.23% Shell 0.08%
covid-19 recover corona coronavirus-tracking covid19 contact-tracing rcvr

rcvr-app's People

Contributors

bitboxer avatar bonflintstone avatar codedoctorde avatar dependabot[bot] avatar devchris avatar endverbraucher avatar fabianbeiner avatar hey-johnnypark avatar koos avatar m0ppers avatar maxkellermann avatar niklas573 avatar p3nny avatar rennrennrenn avatar salimhb avatar sebastiandeutsch avatar stephanpavlovic avatar stringparser avatar thordro avatar timomeh avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

rcvr-app's Issues

wrong locale order in checkin page

Reported by Kira

Problem is recover (in bold) should go after the exclamation mark.

Checkin page before having locales:

rcvr-app/pages/checkin.tsx

Lines 205 to 223 in 638a7c3

<Text>
<p>{introText}</p>
<p>
{formalAddress
? 'So kann das Gesundheitsamt Sie anrufen, wenn es notwendig ist.'
: 'So kann das Gesundheitsamt Dich anrufen, wenn es notwendig ist.'}
</p>
<p>
Datenschutz ist uns dabei sehr wichtig!{' '}
{isRcvrEnv ? (
<>
<strong>recover</strong> speichert Deine Daten verschlüsselt
und sicher.
</>
) : (
'Ihre Daten werden verschlüsselt und sicher gespeichert.'
)}
</p>
</Text>

This bug couldn't be found before since couldn't test the checkin page locally till recently (see #331 )

Let's start a BugBounty!

How about asking some companies to build up a small pool of money to motivate some local experts to review the code for flaws?

To open Corona Warn App link on checkout from Meine Checkins WebView

Hi there.

I'm trying to figure out if is possible to open universal links from meine checkins WebView i.e. Corona Warn App. Currently these links doesn't open in the CWA app but on a new tab on the WebView (asking you to install the app). The ideal would be that on the WebView of meine checkins the link opened just like it does on the browser but somehow it doesn't so I'm looking to why that could be.

For what I can see here

export const generateCwaLink = (checkin: Checkin) => {
// Source for this key: https://github.com/corona-warn-app/cwa-documentation/blob/master/event_registration.md
const public_key = window.atob(
'gwLMzE153tQwAOf2MZoUXXfzWTdlSpfS99iZffmcmxOG9njSK4RTimFOFwDh6t0Tyw8XR01ugDYjtuKwjjuK49Oh83FWct6XpefPi9Skjxvvz53i9gaMmUEc96pbtoaA'
)
const cwaSeed = Uint8Array.from(atob(checkin.cwaSeed), (c) => c.charCodeAt(0))
const payload = QRCodePayload.encode({
version: 1,
locationData: {
version: 1,
description: checkin.business,
address: checkin.address || '',
startTimestamp: 0,
endTimestamp: 0,
},
crowdNotifierData: {
version: 1,
publicKey: base64toUint8(public_key),
cryptographicSeed: cwaSeed,
},
vendorData: CWALocationData.encode({
version: 1,
type: locationType(checkin.locationType),
defaultCheckInLengthInMinutes: checkin.autoCheckoutTime / 60,
}).finish(),
}).finish()
return (
'https://e.coronawarn.app/?v=1#' +
btoa(String.fromCharCode.apply(null, payload))
)
}

in recover is open with window.open so I was wondering if because of this reason.

Do you think the universal link would work if we had an a tag with an href? I'm not sure if that's possible to do on recover for privacy reasons but... if is possible to have an a + href would also make it work from the app by preventing default an opening the link href from there.

If you happen to have a link for testing this first I can see if this would work on the context of webview on meine checkins. Maybe just need an a + href.

improve formals and plurals in locales

To be done after #259 is merged.
see Original post by @bitboxer in #259 (comment)

For formal the translate function in usePageLocales can take account of it since is build dependent (we know it from the start).

We can also add an option like { formal: false} to this translate function so we can override the default.

To improve counts for plurals we can pass count as a second argument and then this can be used by the translation function.

Make required fields configurable

For example, in NRW, only phone number or email address are required (§ 8 CoronaSchVO), not both. For the purpose of data reduction you shouldn't require both from a user when they aren't legally required to provide both.

You could add a configuration for each state and let businesses select which state they are legally bound to.

Some competitive apps also allow to select from a list of required field combinations, but this requires somewhat detailed legal knowledge from business owners and is prone to mistakes.

checkin page translation

Reported by @KiraRL in Slack

Two issues in the checking page translations:

  1. Translation key placeholder [infoText] visible in screen
  2. When changing to en throws error cannot read property ‘companyName’

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.