GithubHelp home page GithubHelp logo

vscode's People

Contributors

daylerees avatar usernamehw avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

vscode's Issues

Use type property for themes

All your themes default to dark. It affects many colors for elements.

"type": "light" | "dark"

In addition from 1.19 themes grouped in theme picker (dark | light | high contrast):
theme-picker

Make the colors differ more for stylesheets (CSS, LESS, etc)

Currently the colors for selectors and properties in stylesheets (CSS, LESS, etc) all are the same and it makes it harder to distinguish. This seems to apply to most off the Rainglow themes for VSCode.

Example LESS file in VSCode (Warlock Contrast)
image

Thanks! πŸ˜„

Goldfish comment barely visible

Hey! awesome theme pack, I found my (almost) perfect theme, Goldfish!
I've been using the latest VSCode, with the latest rainglow pack version.

my issue is rather small, the comments text is too dark imho, and it's almost invisible on diff tool (screenshot provided).
this issue exists in several themes but not in Joker or others.
I assume a few clicks lighter would solve this.

screen shot 2018-03-25 at 16 12 21

I would be happy to submit a PR to fix this, but its your show and art - so your call.
Thanks! :)

Box UK: selected elements highlight visibility

Hi!
On Rainglow, v1.5.2, 'BOX Uk' theme (contrast and non-contrast versions), selected elements are poorly highlighted:
image

The same goes for light versions of the same theme.
I suggest some contrast color be used for better visibility.
Thanks.

After updating to VSCode April release, brackets are colourized.

Not specifically looking to have this patched, but wanted to note it if anyone else starts having this problem and the solution I found:

After updating VSCode to the April 2022 release (v1.67) it has started colourizing brackets by default which is ugly af. It looks like the culprit is the editor.bracketPairColorization.enabled setting. When set, it does what it says and overwrites the theme's colour as seen below:

Screen Shot 2022-05-09 at 15 01 14

By disabling this setting the theme shows as it should:

Screen Shot 2022-05-09 at 15 05 34

Consider using "extensionButton.prominentBackground"

Buttons and badges in extension view has green color that doesn't go together with most of the themes:
extension_prominent_background

It would be nice to use it in themes (not necessarily the same color as badges and input focus, just something that's not stands out in theme context).

Rainglow is broken with short syntax React Fragments

Hello, I have a lot short syntax React fragments in my codebase. Every theme is broken

editor/software are you using?

VSCode

Which theme are you using?

Joker but the problem is present on each theme

Have you tested the issue with other themes?

Yes, the problem is present on each theme

Which version of Rainglow do you have installed?

1.5.2

Can you provide screenshots to highlight the issue?

With short syntax React fragment

screenshot 2019-01-22 at 17 13 41

With long syntax React fragment

screenshot 2019-01-22 at 17 14 41

Coffee Contrast theme unreadable buttons

Hello

First off, thanks for the collection of theme's, it's wonderful!
I really like the Coffee Contrast Theme, but noticed the text in the buttons is unreadable (very bright background with white text).
I thought it would be good to let you know.

  • [] Which editor/software are you using? --> VScode
  • [] Which theme are you using? --> Coffee Contrast
  • [] Which version of Rainglow do you have installed? --> v1.5.2
  • [] Can you provide screenshots to highlight the issue?
    image

Kind regards

Light themes more colorful fonts

I'm using the latest version of everything. And I like the light themes very much, especial the ones that are kinda dark (not too bright and not to dark) like peacocks in space, tron, storm light, etc. But there is a problem with the fonts color. The dark versions of those have a font color that fits more, is more recognizable. So please, make the font colors for light themes more suitable for the theme. Or tell us where we can do some changes manually (like string color, operators, classes, methods, numbers, etc).
Otherwise, keep up the great work.

Thank you.

Causes JSON schema error for settings file

Rainglow version 1.5.2.
No idea why this happens or what's the connection. My user settings JSON file shows this error when the rainglow extension is enabled. There's a squiggly underline in the opening curly brace of my settings file with the message:

Unable to load schema from 'vscode://schemas/settings/user': Request 
vscode/content failed with message: Cannot read property 'getText' of undefined"
  • The user settings are working fine and the changes are picked up.
  • It doesn't happen with any other JSON file.
  • It doesn't happen if I load the settings contents in a new JSON file.

It happens irrespective what theme β€” any rainglow or non-rainglow or the default β€” I choose.

The full output from JSON Language Server:

Trace - 7:12:43 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///c%3A/Users/mehedia/AppData/Roaming/Code/User/settings.json",
    "diagnostics": [
        {
            "severity": 2,
            "range": {
                "start": {
                    "line": 0,
                    "character": 0
                },
                "end": {
                    "line": 0,
                    "character": 1
                }
            },
            "message": "Unable to load schema from 'vscode://schemas/settings/user': Request vscode/content failed with message: Cannot read property 'getText' of undefined"
        }
    ]
}

Versions:
Version 1.20.1
Commit f88bbf9137d24d36d968ea6b2911786bfe103002
Date 2018-02-13T15:34:36.336Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64


Hi there!

Thanks for contributing to Rainglow.

Please try to provide as much of the following information as possible.

  • [] Which editor/software are you using?
  • [] Which theme are you using?
  • [] Have you tested the issue with other themes?
  • [] Which version of Rainglow do you have installed?
  • [] Can you provide screenshots to highlight the issue?

If the above requirements don't make sense, just let me know how I can help. :)

Thanks!
Dayle.

Intellisense illegible with "Potpourri Contrast (rainglow)"

Hey @daylerees ! πŸ˜ŠπŸ‘‹πŸΌ
Wonderful extension.

I'm using VS Code.
I have found a color 'bug' with one of your themes:
"Potpourri Contrast (rainglow)"
immagine
Code completion is almost illegible.
I don't mean to tweak it from settings, because i'm using random theme switcher.
Not a big issue for me, but if you'll find time to fix it, you'll have an even more nice theme collection !
Best !

Remove Markdown restrictions in some scopes

Themes: I believe all of them.

There are a lot of scopes that are Markdown-restricted and have no no-Markdown equivalent.

I'm thinking about entity.name.section.markdown and punctuation.definition.heading.markdown, among others. That's an issue since other languages that use these scopes won't have the headings highlighted. (It's the case for the Inform 7 extension I maintain, for instance.)

(And the same can be said for other scopes such as inline code, bold, italic and so on, of course.)

Unreadable buttons on Tron theme

Thanks for your awesome work on Rainglow, Dayle. πŸ‘

Just wanted to report that the Tron theme is rendering unreadable buttons, white text on top of a white background, as shown on the screenshot below.

The button.background property here

"button.background":"#ffffff",
"button.foreground":"#ffffff",

should actually be

"button.background":"#267fb5",
"button.foreground":"#ffffff",

tron - buttons

Unreadable Color for markdown code block

  • [] Which editor/software are you using? VSCode 1.47.2
  • [] Which theme are you using? Frontier from rainglow
  • [] Have you tested the issue with other themes? freshcut, isotope, kimbie dark from rainglow, One Monokai Theme from Joshua Azemoh
  • [] Which version of Rainglow do you have installed? 1.5.2
  • [] Can you provide screenshots to highlight the issue?

With rainglow
image
freshcut and isotope also have the issue, not kimbie dark.

With One Monokai
image

Comparable Brogrammer Theme

Hey, first of all thanks for you're great work. I love you're themes. But i miss some sort of Brogrammer style theme for the editor. Brogrammer exist in atom for example, but it doesn't seem to update by the maintainer anymore. So my question is, would you like to create some sort of Brogrammer theme in you're style ? :)

For VSCode
For Atom
Intellij doesn't exist unfortunately

Have a great day !
Best regards

Feature Request: Markdown Syntax highlight code ticks

Love love love ❣️ Rainglow Thank you for putting it together. πŸ˜ƒ

I have a Feature Request to Add code tick syntax highlighting to markdown, ".md" files.

Deets

  • Visual Studio Code for Windows v 1.28.1 (as of this writing)
  • Rainglow v 1.5.2
  • Theme: Joker, all
  • Have you tested the issue with other themes?
    • Yes, works with Monokai, but for the most part not any of the Rainglow themes

Example Without Syntax Hightlighting (joker and most themes)

Rainglow-no-code-tick-highlighting

Example With Syntax Hightlighting (monokai themes)

Monokai-with-code-tick-highlighting

Thanks!
JeFF

Support newer versions of Code which include more color customizations

  • Which editor/software are you using? Visual Studio Code 1.69
  • Which theme are you using? I regularly rotate through the dark (non-contrast) themes.
  • Have you tested the issue with other themes? Yes, I have used the built-in themes.
  • Which version of Rainglow do you have installed? 1.5.2
  • Can you provide screenshots to highlight the issue? Yes, see below an example using Spearmint.

Summary

Rainglow unfortunately is out-of-date. While the general color theming still works, recent versions of Code provide more customization points. Please review the picture for reference.

rainglow-missing-colors

The debug toolbar (see debugToolBar.*) does not match the theme, only whether the theme is considered light or dark. Text in the debug view can be hard to read as the default colors for tokens (see debugTokenExpression.*) do not agree with the rest of the theme. As mentioned in #40, Code can now color nested brackets (see editorBracketHighlight.*) which can clash with the theme.

I started working on a script to patch the themes, attempting to fill in some missing colors based on existing one as well as make other corrections to contrast/readability. Unfortunately, the JSON files have duplicate keys. This was noted in #7, but the defect was not resolved in the subsequent releases. Since these duplicate keys often have different values, it is hard to know which color was intended.

Error: ENOENT: no such file or directory, open '/opt/build/repo/node_modules/rainglow/themes/morass.json'

This is pretty straight forward. I using your theme with the gatsby-remark-vscode plugin for GatsbyJS.

It works locally, but when I try to deploy the site to Netlify, I get the following error:

Screen Shot 2021-08-19 at 10 37 36 PM

I guess their build step is case-sensitive. In your package.json:

vscode/package.json

Lines 874 to 878 in 57cbb86

{
"label": "Morass (rainglow)",
"uiTheme": "vs-dark",
"path": "./themes/morass.json"
},

But your filename inside theme is Morass.json

Thanks!

Overflow Light missing comment coloring

For some reason Overflow Light theme is missing the commenting color. Any chance you can add that? All else looks fantastic.

screen shot 2018-10-03 at 6 05 13 am

This fixes it pretty much:

        {
            "name": "Comment",
            "scope": "comment",
            "settings": {
                "foreground": "#aaaaaa"
            }
        },

Completion menu color is incorrect

  • Which editor/software are you using? Visual Studio Code 1.57.0
  • Which theme are you using? Blink
  • Have you tested the issue with other themes? Yes
  • Which version of Rainglow do you have installed? 1.5.2
  • Can you provide screenshots to highlight the issue?

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2021-06-17 165535
γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2021-06-17 165613

VS Code now has a "breadcrumbs" feature, which could use some styling

  • Which editor/software are you using? VS Code
  • Which theme are you using? Legacy
  • Have you tested the issue with other themes? Not an issue
  • Which version of Rainglow do you have installed? 1.5.2
  • Can you provide screenshots to highlight the issue?

As you can see under the tabs, there is a row of breadcrumbs which currently looks kind of cramped.

image

No themes with dark status bars?

Most themes have bright contrasting status bars... I tend to prefer themes with dark status bars or that blend in with the editor background color.

Ligature Font operator?

Are you guys going to have the Operator font ligature support in your theme anytime soon?

Terminal Colors

Hi guys, I noticed that in my vscode terminal colors are not affected by themes.
I am currently running the latest version of vscode with Ubuntu 17.10 as OS.

String selector leaks through template literal

There is a known bug which affects at least javascript & typescript: Items without selector inherit string color:

   [1,2,3].title;
`${[1,2,3].title}`

leakingcolor

There is 1 easy fix though: add to "tokenColors":

{
    "scope": "meta.template.expression",
    "settings": {
        "foreground": "#aec2e0"
    }
}

It was example for the legacy theme. This color should be the same as "editor.foreground" of the same theme.

If you want I can create a PR to fix this.

Change highlight folder color?

Hello,

Is there a way to change the pink highlight color on the folder tree structure section whenever a user clicks on the folder to expand what is inside?

Thanks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.