rali-udem / simplenlg-enfr Goto Github PK

In looking at the default French lexicon, I noticed this:

    <word>
        <base>abaisser</base>
        <category>verb</category>
        <id>abaisser_1</id>
    </word>

where I would have expected this

    <word>
        <base>abaisser</base>
        <category>verb</category>
        <id>E0038108</id>
    </word>

Is it correct to assume that the lexicon would be improved if this mapping was updated, or is there a reason why it hasn't been done for all verbs.

Should this mapping be updated in default_french_lexicon.xml or in a new lexicon?

L'ajout de l'indicatif passé simple et passé antérieur et du
subjonctif imparfait et plus-que-parfait n'est pas envisagé, leur utilité pratique n'étant pas jugée
suffisante.

I wonder how hard it would be to add this. It would be a nice step forward for this library.

When building the project with Maven (clean install targets). Many tests are in error.

Tests in error: testBasics(simplenlg.test.english.MultipleLexiconTest) testMultipleSpecifics(simplenlg.test.english.MultipleLexiconTest) testBasics(simplenlg.test.english.NIHDBLexiconTest) testStandardInflections(simplenlg.test.english.NIHDBLexiconTest) testAcronyms(simplenlg.test.english.NIHDBLexiconTest) testBasics(simplenlg.test.french.MultipleLexiconTest) testBasics(simplenlg.test.french.MultipleLexiconTest) testMultipleSpecifics(simplenlg.test.french.MultipleLexiconTest) testMultipleSpecifics(simplenlg.test.french.MultipleLexiconTest) testBasics(simplenlg.test.MultipleLexiconTest) testMultipleSpecifics(simplenlg.test.MultipleLexiconTest) testBasics(simplenlg.test.NIHDBLexiconTest) testStandardInflections(simplenlg.test.NIHDBLexiconTest) testAcronyms(simplenlg.test.NIHDBLexiconTest)

Hi,

we are working for creating the SimpleNLG extension for the italian language. We studied the SimpleNLG architecture and the SimpleNLGFrench modifications to the architecture.
Is it better to implement the processors as classes that implement the NLGModule or to implement the processors as part of an NLG element (french approach). What are the disavantages of these two approaches?

This is the ultimate issue for this project :-)

rali-udem/SimpleNLG-EnFr should be dependent of the original simplenlg/simplenlg, and not a rewrite

Many enhancements have been made on the english project since the fork and it will be difficult to report them on the french one.

In french, when multiple premodifiers, the realisation does not separate them with commas :

PhraseElement np = this.factory.createNounPhrase("le", "bateau");
np.addPreModifier(this.lexicon.getWord("beau", LexicalCategory.ADJECTIVE));
np.addPreModifier(this.lexicon.getWord("grand", LexicalCategory.ADJECTIVE));

=> le beau grand bateau
While in english, it does :

PhraseElement np = this.phraseFactory.createNounPhrase("the", "boat");
np.addPreModifier(this.lexicon.getWord("big", LexicalCategory.ADJECTIVE));
np.addPreModifier(this.lexicon.getWord("beautiful", LexicalCategory.ADJECTIVE));

=> the big, beautiful boat

Meanwhile, in the original https://github.com/simplenlg/simplenlg project, a commaSepPremodifiers option has been added to the OrthographyProcessor to deactivate the comma separation of the premodifiers. However, in SimpleNLG-enfr the OrthographyProcessor is unused and has been replaced by OrthographyHelpers which is not as accessible and cannot support this option.

Thus, the realisation of multiple premodifiers doesn't behave the same way in english and french and cannot be changed.

As started stated in #8, a more Maven compliant organization would be nice, as done in

• simplenlg/simplenlg@f566180
• https://github.com/gmontcheuil/SimpleNLG-EnFr/commits/master

Bonjour,

Comment peut-on définir un nombre précis pour un nom?

Par exemple:
Vous avez deux travaux supplémentaires

Merci

Hi, I want to know how would I get a sentence like this?
Vous vouliez connaitre la vérité

Hello,

I want to make a change to the XMLLexicon, but the Junits are failing for me on master. Are you seeing this as well, or is it a problem with my build.

Loading XML lexicon took 699 ms

junit.framework.ComparisonFailure: 
Expected :eat
Actual   :eating
 <Click to see difference>
    at simplenlg.test.SharedLexiconTests.doBasicTests(SharedLexiconTests.java:110)
    at simplenlg.test.XMLLexiconTest.testBasics(XMLLexiconTest.java:70)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
    at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:74)
    at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:211)
    at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:67)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at com.intellij.rt.execution.application.AppMain.main(AppMain.java:134)


Process finished with exit code 255